-
-
Notifications
You must be signed in to change notification settings - Fork 372
fix: UIWindow being possibly accessed from a background thread in SentryCrashWrapper #6905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UIWindow being possibly accessed from a background thread in SentryCrashWrapper #6905
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6905 +/- ##
=============================================
+ Coverage 84.928% 84.931% +0.002%
=============================================
Files 453 453
Lines 27609 27621 +12
Branches 12123 12127 +4
=============================================
+ Hits 23448 23459 +11
+ Misses 4116 4114 -2
- Partials 45 48 +3
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 48e5c8a | 1223.02 ms | 1242.38 ms | 19.35 ms |
| 8fd192f | 1202.10 ms | 1220.19 ms | 18.09 ms |
| 5200f5b | 1231.73 ms | 1254.35 ms | 22.62 ms |
| f8cad3c | 1217.94 ms | 1257.96 ms | 40.02 ms |
| abe8da4 | 1232.98 ms | 1259.12 ms | 26.14 ms |
| 4be5cd8 | 1222.35 ms | 1251.43 ms | 29.07 ms |
| af7a86c | 1220.82 ms | 1243.36 ms | 22.54 ms |
| 52f3b6e | 1219.57 ms | 1239.70 ms | 20.13 ms |
| ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
| 1339919 | 1214.82 ms | 1238.98 ms | 24.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 48e5c8a | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 8fd192f | 23.74 KiB | 872.75 KiB | 849.01 KiB |
| 5200f5b | 23.75 KiB | 933.33 KiB | 909.58 KiB |
| f8cad3c | 23.75 KiB | 1.01 MiB | 1016.13 KiB |
| abe8da4 | 23.75 KiB | 987.95 KiB | 964.21 KiB |
| 4be5cd8 | 23.75 KiB | 980.80 KiB | 957.06 KiB |
| af7a86c | 23.74 KiB | 926.65 KiB | 902.90 KiB |
| 52f3b6e | 23.75 KiB | 920.54 KiB | 896.79 KiB |
| ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
| 1339919 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
…creen-to-main-thread-in
…coa-422-dispatch-access-of-uiwindow-screen-to-main-thread-in
Under some scenarios, calling
addBreadcrumbin the background, may en up in SentryCrashWrapper using UIWindows in the background thread.Since all we need is the window's size, this is enough.
Closes: #5424