fix(session-replay): Ignore list background decoration view in redaction #6292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6502818 | 1229.08 ms | 1245.46 ms | 16.37 ms |
| ed85746 | 1231.79 ms | 1248.55 ms | 16.75 ms |
| daeb716 | 1215.41 ms | 1246.52 ms | 31.11 ms |
| 331dad6 | 1210.40 ms | 1242.06 ms | 31.67 ms |
| cda95fc | 1231.42 ms | 1247.18 ms | 15.77 ms |
| 2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
| bc0a04c | 1226.83 ms | 1255.04 ms | 28.21 ms |
| aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
| e8da57d | 1203.77 ms | 1234.85 ms | 31.08 ms |
| 3b373bb | 1218.19 ms | 1250.57 ms | 32.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6502818 | 23.75 KiB | 959.45 KiB | 935.70 KiB |
| ed85746 | 23.75 KiB | 920.83 KiB | 897.08 KiB |
| daeb716 | 23.75 KiB | 928.16 KiB | 904.41 KiB |
| 331dad6 | 23.75 KiB | 928.12 KiB | 904.37 KiB |
| cda95fc | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| 2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
| bc0a04c | 23.75 KiB | 933.32 KiB | 909.57 KiB |
| aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
| e8da57d | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 3b373bb | 23.75 KiB | 947.72 KiB | 923.97 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Ignores the decoration view used in SwiftUI from the redaction algorithm.
💡 Motivation and Context
One screen of the dogfooding app Flinky had the following masking issue in a screen where a Grid and a List are inside a VStack, where the entire top half was unmasked:
Further analysis using
(lldb) po view.value(forKey: "recursiveDescription")!surfaced that theSwiftUI.Listis implemented as aSwiftUI.UpdateCoalescingCollectionView, a subclass ofUICollectionView, which uses a_UICollectionViewListLayoutSectionBackgroundColorDecorationViewto display its background color.This background view massively overextends the list bounds with it's frame of
(-20 -1135.33; 442 2336)and causes calculation issues in the clipping.The easiest solution for now was simply ignoring the view from the redaction algorithm.
💚 How did you test it?
I used the Flinky project with a locally checked out Sentry Cocoa SDK repo and directly compiled it. After running the app I checked the replay in Sentry.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.