-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Create file io tracker Swift interface #6274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6274 +/- ##
=============================================
- Coverage 86.714% 7.538% -79.177%
=============================================
Files 437 403 -34
Lines 37132 35407 -1725
Branches 17383 13968 -3415
=============================================
- Hits 32199 2669 -29530
- Misses 4660 32728 +28068
+ Partials 273 10 -263
... and 415 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a44f168
to
7863088
Compare
I'm not sure why this only fails to compile for static builds, converting it to draft while I investigate |
7863088
to
ff34dd4
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
effeafa | 1225.88 ms | 1249.78 ms | 23.90 ms |
18be519 | 1241.22 ms | 1260.57 ms | 19.35 ms |
e0424b9 | 1204.23 ms | 1241.08 ms | 36.85 ms |
073562b | 1232.63 ms | 1259.88 ms | 27.24 ms |
3ffd0e5 | 1228.04 ms | 1253.04 ms | 25.00 ms |
bbe6658 | 1221.00 ms | 1248.51 ms | 27.51 ms |
f8029e2 | 1245.16 ms | 1261.32 ms | 16.16 ms |
b193842 | 1231.36 ms | 1247.69 ms | 16.33 ms |
1f48bb7 | 1223.83 ms | 1241.85 ms | 18.02 ms |
80a5166 | 1224.49 ms | 1251.29 ms | 26.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
effeafa | 23.74 KiB | 926.64 KiB | 902.89 KiB |
18be519 | 23.75 KiB | 926.64 KiB | 902.90 KiB |
e0424b9 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
073562b | 23.75 KiB | 927.06 KiB | 903.31 KiB |
3ffd0e5 | 23.75 KiB | 947.55 KiB | 923.80 KiB |
bbe6658 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
f8029e2 | 23.75 KiB | 893.72 KiB | 869.97 KiB |
b193842 | 23.75 KiB | 920.65 KiB | 896.90 KiB |
1f48bb7 | 23.75 KiB | 971.98 KiB | 948.24 KiB |
80a5166 | 23.75 KiB | 904.53 KiB | 880.78 KiB |
Resolves https://linear.app/getsentry/issue/COCOA-709/convert-sentryfileiotracker
#skip-changelog