Skip to content

Conversation

noahsmartin
Copy link
Contributor

Copy link

linear bot commented Sep 24, 2025

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.538%. Comparing base (d8ceea3) to head (ff34dd4).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryDependencyContainer.m 0.000% 3 Missing ⚠️
Sources/Sentry/SentryFileIOTracker.m 0.000% 1 Missing ⚠️
Sources/Sentry/SentryFileIOTrackingIntegration.m 0.000% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (d8ceea3) and HEAD (ff34dd4). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (d8ceea3) HEAD (ff34dd4)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #6274        +/-   ##
=============================================
- Coverage   86.714%   7.538%   -79.177%     
=============================================
  Files          437      403        -34     
  Lines        37132    35407      -1725     
  Branches     17383    13968      -3415     
=============================================
- Hits         32199     2669     -29530     
- Misses        4660    32728     +28068     
+ Partials       273       10       -263     
Files with missing lines Coverage Δ
Sources/Sentry/SentryNSDataSwizzling.m 0.000% <ø> (-100.000%) ⬇️
Sources/Sentry/SentryNSFileManagerSwizzling.m 0.000% <ø> (-100.000%) ⬇️
Sources/Sentry/SentryFileIOTracker.m 0.000% <0.000%> (-95.556%) ⬇️
Sources/Sentry/SentryFileIOTrackingIntegration.m 0.000% <0.000%> (-100.000%) ⬇️
Sources/Sentry/SentryDependencyContainer.m 34.439% <0.000%> (-55.056%) ⬇️

... and 415 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ceea3...ff34dd4. Read the comment docs.

@noahsmartin noahsmartin force-pushed the fileIOTrackerSwift branch 2 times, most recently from a44f168 to 7863088 Compare September 24, 2025 19:37
@noahsmartin
Copy link
Contributor Author

I'm not sure why this only fails to compile for static builds, converting it to draft while I investigate

@noahsmartin noahsmartin marked this pull request as draft September 25, 2025 01:34
Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryNSDataSwizzling.m
  • Sources/Sentry/SentryNSFileManagerSwizzling.m

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.31 ms 1247.20 ms 28.90 ms
Size 23.75 KiB 981.16 KiB 957.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
effeafa 1225.88 ms 1249.78 ms 23.90 ms
18be519 1241.22 ms 1260.57 ms 19.35 ms
e0424b9 1204.23 ms 1241.08 ms 36.85 ms
073562b 1232.63 ms 1259.88 ms 27.24 ms
3ffd0e5 1228.04 ms 1253.04 ms 25.00 ms
bbe6658 1221.00 ms 1248.51 ms 27.51 ms
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
b193842 1231.36 ms 1247.69 ms 16.33 ms
1f48bb7 1223.83 ms 1241.85 ms 18.02 ms
80a5166 1224.49 ms 1251.29 ms 26.80 ms

App size

Revision Plain With Sentry Diff
effeafa 23.74 KiB 926.64 KiB 902.89 KiB
18be519 23.75 KiB 926.64 KiB 902.90 KiB
e0424b9 23.74 KiB 874.07 KiB 850.33 KiB
073562b 23.75 KiB 927.06 KiB 903.31 KiB
3ffd0e5 23.75 KiB 947.55 KiB 923.80 KiB
bbe6658 23.75 KiB 908.02 KiB 884.27 KiB
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
b193842 23.75 KiB 920.65 KiB 896.90 KiB
1f48bb7 23.75 KiB 971.98 KiB 948.24 KiB
80a5166 23.75 KiB 904.53 KiB 880.78 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant