ref: SentryPerformanceTracker in Swift

[noahsmartin]

This depends on #6417

This PR will close https://linear.app/getsentry/issue/COCOA-554/convert-sentryperformancetracker-to-swift

#skip-changelog

[codecov]

Codecov Report

❌ Patch coverage is 54.00000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 7.607%. Comparing base (f747c9c) to head (3c66029).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ce/UIViewController/SentryPerformanceTracker.swift	54.347%	21 Missing ⚠️
.../Sentry/SentryUIViewControllerPerformanceTracker.m	33.333%	2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f747c9c) and HEAD (3c66029). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (f747c9c)	HEAD (3c66029)
	3	1

Additional details and impacted files

@@              Coverage Diff              @@
##              main    #6271        +/-   ##
=============================================
- Coverage   86.772%   7.607%   -79.165%     
=============================================
  Files          441      408        -33     
  Lines        37285    35610      -1675     
  Branches     17345    14001      -3344     
=============================================
- Hits         32353     2709     -29644     
- Misses        4888    32889     +28001     
+ Partials        44       12        -32     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryDependencyContainer.m	38.589% <ø> (-51.453%)	⬇️
Sources/Sentry/SentryHub.m	16.315% <ø> (-80.351%)	⬇️
Sources/Sentry/SentryPerformanceTrackerHelper.m	69.461% <100.000%> (ø)
Sources/SentrySwiftUI/SentryTracedView.swift	70.370% <ø> (ø)
.../Sentry/SentryUIViewControllerPerformanceTracker.m	12.010% <33.333%> (-86.946%)	⬇️
...ce/UIViewController/SentryPerformanceTracker.swift	54.347% <54.347%> (ø)

... and 421 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f747c9c...3c66029. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1221.31 ms	1253.90 ms	32.59 ms
Size	23.75 KiB	998.01 KiB	974.26 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
e3767a1	1224.20 ms	1257.16 ms	32.96 ms
b115f82	1212.96 ms	1251.92 ms	38.96 ms
438caec	1230.02 ms	1250.00 ms	19.98 ms
7d23639	1237.93 ms	1243.04 ms	5.11 ms
e64d3d4	1241.90 ms	1260.10 ms	18.20 ms
5200f5b	1231.73 ms	1254.35 ms	22.62 ms
701acf0	1230.24 ms	1255.60 ms	25.36 ms
2675d3c	1218.94 ms	1239.36 ms	20.42 ms
80538ca	1216.70 ms	1253.92 ms	37.22 ms
884b224	1233.41 ms	1259.50 ms	26.09 ms

App size

Revision	Plain	With Sentry	Diff
e3767a1	23.75 KiB	913.14 KiB	889.39 KiB
b115f82	23.75 KiB	989.04 KiB	965.30 KiB
438caec	23.74 KiB	913.14 KiB	889.40 KiB
7d23639	23.75 KiB	891.01 KiB	867.26 KiB
e64d3d4	23.75 KiB	855.37 KiB	831.62 KiB
5200f5b	23.75 KiB	933.33 KiB	909.58 KiB
701acf0	23.75 KiB	987.96 KiB	964.21 KiB
2675d3c	23.75 KiB	928.16 KiB	904.41 KiB
80538ca	23.75 KiB	989.99 KiB	966.24 KiB
884b224	23.75 KiB	879.60 KiB	855.86 KiB

Previous results on branch: performanceTrackerSwift

Startup times

Revision	Plain	With Sentry	Diff
2dcf808	1217.09 ms	1249.37 ms	32.28 ms
4e0213e	1230.06 ms	1258.98 ms	28.92 ms
360791c	1227.61 ms	1268.07 ms	40.46 ms
38cbfc6	1223.93 ms	1257.56 ms	33.62 ms
47c237d	1222.31 ms	1241.70 ms	19.40 ms

App size

Revision	Plain	With Sentry	Diff
2dcf808	23.75 KiB	997.36 KiB	973.62 KiB
4e0213e	23.75 KiB	997.91 KiB	974.16 KiB
360791c	23.75 KiB	997.38 KiB	973.63 KiB
38cbfc6	23.75 KiB	997.91 KiB	974.16 KiB
47c237d	23.75 KiB	996.03 KiB	972.28 KiB

[linear]

COCOA-554 Convert SentryPerformanceTracker to Swift

[itaybre]

Do you mind adding that the source is expected to be a value of SentryTransactionNameSource?

[philipphofmann]

And also maybe explain why we can't use it here in the comment please.

[itaybre]

LGTM, with a small comment

[philipphofmann]

Thank you, @noahsmartin

[philipphofmann]

And also maybe explain why we can't use it here in the comment please.

[philipphofmann]

l: I don't think we need these comments here and also for the SentryPerformanceTrackerHelper.h. Maybe we could remove them at one place, so we don't have to maintain both.

[noahsmartin]

I don't think this will be necessary for the dependency container to be in Swift, so going to close it for now