-
-
Notifications
You must be signed in to change notification settings - Fork 366
test: Add SwiftUI test to reproduce SwiftUI lifecycle only bugs #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It would be great to make the PR title a bit more specific and mention the related issues in the PR description please.
fe8094d
to
445ca06
Compare
445ca06
to
975c7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to make the PR title a bit more specific and mention the related issues in the PR description please.
Again LGTM with a nitpick
975c7bf
to
be6cc0e
Compare
Add a test to capture error in SwiftUI test app, reproduces the error fixed by #6264
#skip-changelog
Closes #6269
Note
Adds a UITest to assert
capture(error:)
returns a non-empty Sentry ID and updates the SwiftUI sample to surface that ID for testing.Samples/iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift
):Sentry
.testCaptureErrorReturnsValidId
that taps "Capture Error", readserrorId
, buildsSentryId
, and asserts it’s not empty.Samples/iOS-SwiftUI/iOS-SwiftUI/ContentView.swift
):@State var errorId: SentryId?
and display it withaccessibilityIdentifier
errorId
.captureErrorAction
to a function that captures the error and stores the returnedSentryId
in state.Written by Cursor Bugbot for commit be6cc0e. This will update automatically on new commits. Configure here.