-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Update SentryCrashReportConverter for improved nullability handling #6208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philprime
wants to merge
11
commits into
main
Choose a base branch
from
philprime/fix-crash-reporter-null-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed SentryKSCrashReportConverterTests to SentryCrashReportConverterTests for consistency. - Enhanced nullability checks in SentryCrashReportConverter to prevent potential crashes. - Added new test cases to validate handling of various edge cases in crash report conversion.
@cursor review |
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b3f1af | 1227.04 ms | 1253.35 ms | 26.31 ms |
25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
04ff3ec | 1220.71 ms | 1253.86 ms | 33.15 ms |
cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
8fd192f | 1202.10 ms | 1220.19 ms | 18.09 ms |
e70670c | 1223.47 ms | 1238.67 ms | 15.20 ms |
605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
be8375a | 1212.65 ms | 1239.72 ms | 27.08 ms |
48e5c8a | 1223.02 ms | 1242.38 ms | 19.35 ms |
00d9740 | 1223.53 ms | 1249.75 ms | 26.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b3f1af | 23.75 KiB | 981.30 KiB | 957.56 KiB |
25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
04ff3ec | 23.75 KiB | 880.26 KiB | 856.52 KiB |
cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
8fd192f | 23.74 KiB | 872.75 KiB | 849.01 KiB |
e70670c | 23.75 KiB | 975.19 KiB | 951.45 KiB |
605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
be8375a | 23.75 KiB | 933.03 KiB | 909.28 KiB |
48e5c8a | 23.75 KiB | 913.63 KiB | 889.88 KiB |
00d9740 | 23.75 KiB | 938.32 KiB | 914.57 KiB |
Previous results on branch: philprime/fix-crash-reporter-null-handling
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f6473 | 1223.04 ms | 1251.38 ms | 28.33 ms |
81f34e6 | 1222.77 ms | 1248.67 ms | 25.90 ms |
88d138b | 1222.39 ms | 1253.94 ms | 31.55 ms |
97f2294 | 1217.53 ms | 1250.04 ms | 32.51 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
94f6473 | 23.75 KiB | 977.41 KiB | 953.66 KiB |
81f34e6 | 23.74 KiB | 976.91 KiB | 953.17 KiB |
88d138b | 23.74 KiB | 977.01 KiB | 953.27 KiB |
97f2294 | 23.75 KiB | 980.98 KiB | 957.23 KiB |
…eporter-null-handling
philprime
commented
Sep 23, 2025
philprime
commented
Sep 23, 2025
philprime
commented
Sep 23, 2025
…eporter-null-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Closes #6207
#skip-changelog