Skip to content

Conversation

philprime
Copy link
Member

📜 Description

  • Renamed SentryKSCrashReportConverterTests to SentryCrashReportConverterTests for consistency.
  • Enhanced nullability checks in SentryCrashReportConverter to prevent potential crashes.
  • Added new test cases to validate handling of various edge cases in crash report conversion.

💡 Motivation and Context

Closes #6207

#skip-changelog

- Renamed SentryKSCrashReportConverterTests to SentryCrashReportConverterTests for consistency.
- Enhanced nullability checks in SentryCrashReportConverter to prevent potential crashes.
- Added new test cases to validate handling of various edge cases in crash report conversion.
@philprime
Copy link
Member Author

@cursor review

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Sep 19, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
3977 4 3973 11
View the top 3 failed test(s) by shortest run time
SentryTests.SentryANRTrackerV1Tests::testMultipleListeners
Stack Traces | 0s run time
.../Integrations/ANR/SentryANRTrackerV1Tests.swift:78 - Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "ANR Detection".
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:11 - Failed to get background assertion for target app with pid 30682: Timed out while acquiring background assertion.
iOS_SwiftUI_UITests.LaunchUITests::testNoNewTransactionForSecondCallToBody
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:81 - Failed to get background assertion for target app with pid 30730: Timed out while acquiring background assertion.
iOS_SwiftUI_UITests.LaunchUITests::testTransactionSpan
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:81 - Failed to get background assertion for target app with pid 30808: Timed out while acquiring background assertion.
iOS_Swift_UITests.LaunchUITests::testNavigationTransaction
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Sep 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1240.37 ms 1265.08 ms 24.72 ms
Size 23.75 KiB 981.46 KiB 957.72 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b3f1af 1227.04 ms 1253.35 ms 26.31 ms
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms
04ff3ec 1220.71 ms 1253.86 ms 33.15 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
e70670c 1223.47 ms 1238.67 ms 15.20 ms
605fa27 1226.31 ms 1251.35 ms 25.05 ms
be8375a 1212.65 ms 1239.72 ms 27.08 ms
48e5c8a 1223.02 ms 1242.38 ms 19.35 ms
00d9740 1223.53 ms 1249.75 ms 26.22 ms

App size

Revision Plain With Sentry Diff
4b3f1af 23.75 KiB 981.30 KiB 957.56 KiB
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB
04ff3ec 23.75 KiB 880.26 KiB 856.52 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
e70670c 23.75 KiB 975.19 KiB 951.45 KiB
605fa27 23.75 KiB 908.03 KiB 884.28 KiB
be8375a 23.75 KiB 933.03 KiB 909.28 KiB
48e5c8a 23.75 KiB 913.63 KiB 889.88 KiB
00d9740 23.75 KiB 938.32 KiB 914.57 KiB

Previous results on branch: philprime/fix-crash-reporter-null-handling

Startup times

Revision Plain With Sentry Diff
94f6473 1223.04 ms 1251.38 ms 28.33 ms
81f34e6 1222.77 ms 1248.67 ms 25.90 ms
88d138b 1222.39 ms 1253.94 ms 31.55 ms
97f2294 1217.53 ms 1250.04 ms 32.51 ms

App size

Revision Plain With Sentry Diff
94f6473 23.75 KiB 977.41 KiB 953.66 KiB
81f34e6 23.74 KiB 976.91 KiB 953.17 KiB
88d138b 23.74 KiB 977.01 KiB 953.27 KiB
97f2294 23.75 KiB 980.98 KiB 957.23 KiB

@philprime philprime marked this pull request as ready for review September 22, 2025 08:51
cursor[bot]

This comment was marked as outdated.

@philprime philprime marked this pull request as draft September 22, 2025 09:46
@philprime philprime self-assigned this Sep 22, 2025
@philprime
Copy link
Member Author

@cursor review
@sentry review

cursor[bot]

This comment was marked as outdated.

@philprime philprime marked this pull request as ready for review September 23, 2025 11:56
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nullability in SentryCrashReportConverter.m
3 participants