Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Jul 23, 2025

According to github docs: https://github.com/actions/runner-images?tab=readme-ov-file
macos-13 does not use arm64 machines

There are a few macos-13 remaining but used for Xcode 14.
When runners are deprecated in september, we will update those

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.701%. Comparing base (7ef7ab8) to head (bdbb381).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5693       +/-   ##
=============================================
+ Coverage   86.210%   86.701%   +0.491%     
=============================================
  Files          421       422        +1     
  Lines        36019     36094       +75     
  Branches     15234     16997     +1763     
=============================================
+ Hits         31052     31294      +242     
+ Misses        4926      4519      -407     
- Partials        41       281      +240     

see 77 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef7ab8...bdbb381. Read the comment docs.

@itaybre itaybre marked this pull request as ready for review July 23, 2025 20:10
Copy link
Member

@armcknight armcknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, although I just wanted to be sure all the changes here are required for the macOS image version upgrade, or are there other unrelated changes here?

@itaybre itaybre marked this pull request as draft July 23, 2025 20:52
@itaybre
Copy link
Contributor Author

itaybre commented Jul 23, 2025

Moving this back to draft, there are some changes I am aplying in others PR which should unlock more runners to be upgraded

Copy link
Contributor

github-actions bot commented Jul 24, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.14 ms 1228.90 ms 20.76 ms
Size 23.75 KiB 906.02 KiB 882.27 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2481950 1221.04 ms 1248.98 ms 27.94 ms
a9fac2e 1212.45 ms 1219.67 ms 7.22 ms
99104c9 1224.84 ms 1247.08 ms 22.24 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms
6279992 1213.60 ms 1241.38 ms 27.79 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms
fc0757d 1231.83 ms 1248.98 ms 17.15 ms
7c7ac56 1225.90 ms 1250.22 ms 24.33 ms
8e3a42f 1222.90 ms 1245.67 ms 22.77 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms

App size

Revision Plain With Sentry Diff
2481950 23.74 KiB 872.74 KiB 849.00 KiB
a9fac2e 23.75 KiB 879.53 KiB 855.78 KiB
99104c9 23.75 KiB 894.83 KiB 871.09 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB
6279992 23.75 KiB 891.03 KiB 867.28 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
fc0757d 23.75 KiB 850.73 KiB 826.98 KiB
7c7ac56 23.75 KiB 902.49 KiB 878.74 KiB
8e3a42f 23.75 KiB 880.06 KiB 856.31 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB

@itaybre itaybre marked this pull request as ready for review July 24, 2025 18:01
@itaybre itaybre merged commit 721d8f1 into main Jul 24, 2025
115 of 118 checks passed
@itaybre itaybre deleted the itay/ci_bump_macos_runner branch July 24, 2025 18:56
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants