ref: Assume chunk uploading support #3064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
added a commit
that referenced
this pull request
Jan 9, 2026
### Description Assume that the Sentry server supports all file types we would like to upload. This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which [can receive chunk-uploaded ProGuard files](getsentry/sentry@7c7e79f), but [does not declare support in the `accept` field, yet](getsentry/sentry@e0b7ff2). This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1. We also no longer check the `accept` field during `dart-symbol-map` and `build` uploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features. ### Issues - Resolves #3050 - Resolves [CLI-254](https://linear.app/getsentry/issue/CLI-254/assume-chunk-upload-support)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assume-support
branch
from
76ef9b2 to
4a07b44
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Jan 9, 2026
### Description Assume that the Sentry server supports all file types we would like to upload. This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which [can receive chunk-uploaded ProGuard files](getsentry/sentry@7c7e79f), but [does not declare support in the `accept` field, yet](getsentry/sentry@e0b7ff2). This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1. We also no longer check the `accept` field during `dart-symbol-map` and `build` uploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features. ### Issues - Resolves #3050 - Resolves [CLI-254](https://linear.app/getsentry/issue/CLI-254/assume-chunk-upload-support)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assume-support
branch
from
4a07b44 to
9108787
Compare
lcian
approved these changes
Jan 9, 2026
Member
lcian
left a comment
lcian
left a comment
There was a problem hiding this comment.
What error will I get now if I try to upload a Dart symbol map and my server doesn't support it?
Member
Author
|
Depends whether the file is able to complete assembly quickly or not. It's possible there is no error, but if you rerun with the same file after assembly finishes, you should get an error message "unsupported file type" error. |
szokeasaurusrex
added a commit
that referenced
this pull request
Jan 9, 2026
### Description Assume that the Sentry server supports all file types we would like to upload. This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which [can receive chunk-uploaded ProGuard files](getsentry/sentry@7c7e79f), but [does not declare support in the `accept` field, yet](getsentry/sentry@e0b7ff2). This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1. We also no longer check the `accept` field during `dart-symbol-map` and `build` uploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features. ### Issues - Resolves #3050 - Resolves [CLI-254](https://linear.app/getsentry/issue/CLI-254/assume-chunk-upload-support)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assume-support
branch
from
9108787 to
7d7c3b7
Compare
szokeasaurusrex
commented
Jan 9, 2026
Member
Author
There was a problem hiding this comment.
Adding a long_about apparently causes clap to completely reformat the help text
szokeasaurusrex
added a commit
that referenced
this pull request
Jan 9, 2026
### Description Assume that the Sentry server supports all file types we would like to upload. This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which [can receive chunk-uploaded ProGuard files](getsentry/sentry@7c7e79f), but [does not declare support in the `accept` field, yet](getsentry/sentry@e0b7ff2). This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1. We also no longer check the `accept` field during `dart-symbol-map` and `build` uploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features. ### Issues - Resolves #3050 - Resolves [CLI-254](https://linear.app/getsentry/issue/CLI-254/assume-chunk-upload-support)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assume-support
branch
from
7d7c3b7 to
14894a9
Compare
### Description Assume that the Sentry server supports all file types we would like to upload. This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which [can receive chunk-uploaded ProGuard files](getsentry/sentry@7c7e79f), but [does not declare support in the `accept` field, yet](getsentry/sentry@e0b7ff2). This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1. We also no longer check the `accept` field during `dart-symbol-map` and `build` uploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features. ### Issues - Resolves #3050 - Resolves [CLI-254](https://linear.app/getsentry/issue/CLI-254/assume-chunk-upload-support)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assume-support
branch
from
14894a9 to
4b0c2c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assume that the Sentry server supports all file types we would like to upload.
This change fixes compatibility with uploading ProGuard files self-hosted version 24.11.1, which can receive chunk-uploaded ProGuard files, but does not declare support in the
acceptfield, yet. This will allow us to expand Sentry CLI 3.x's official support to all self-hosted versions above 24.11.1.We also no longer check the
acceptfield duringdart-symbol-mapandbuilduploads. As not all versions ≥24.11.1 support these features, this means that users on a self-hosted version that supports these features tries to use the command, they will no longer get an error message that states that their server lacks uploading support for those file types if they attempt to upload it. But, I think this is okay, as long as we are clear what versions are supported for these features.Issues