feat(taskbroker): port profiles consumer to taskbroker raw mode#4386
Conversation
Remove the dedicated ingest-profiles consumer and consume the profiles topic via taskbroker raw passthrough mode instead. Retries and the deadletter route onto the existing taskworker / taskworker-dlq topics. ref STREAM-1248 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Failing integration test is not related to this PR. |
aldy505
left a comment
There was a problem hiding this comment.
I wonder how would you scale this for high throughput ingest traffic?
|
Notes to myself: This is a fix for another integration test as sentry nightly does not have / support Failing line: But the unhealthy |
you can horizontally scale taskworker normally. eventually it will overload taskbroker. scaling taskbroker horizontally is a bit tricky right now (basically, you have to create a new container with its own volumes and grpc port, then point new taskworkers to it), but we're hoping to fix that too in a few months. |
sorry about that. we were planning to delete the code after migrating self-hosted (although, not waiting for a self-hosted release) -- we only realized today that profiles was never ported in self-hosted |
oh so this was the culprit for the failing e2e tests (slack msg) all along? |
|
re scaling, it seems we already have scaling docs. fundamentally nothing changes, only the config format. you can split out the topic into a new, separate taskbroker too if you really want (similar to namespaces) |
getsentry/sentry#117912 was merged on jun 17th, so possibly. but it then got reverted and only reapplied on jun 22nd, so not sure if it explains every failure. |
It doesn't seem so, after merging this PR, |
|
I think we have to give My plan is to close / open it multiple times to see if it gets passed all the times :) |
|
i see two failures:
i'm adding some debug logs for process-spans: getsentry/sentry#118444 but it's not clear to me that this is the thing that causes the integration tests to fail. it's just something i found in the logs. |
Replaces the dedicated
ingest-profilesconsumer with taskbroker raw mode. This must be merged before the next sentry release, as the consumer code is already gone.We're going to tear down the following consumers in sentry:
they're not all blocking the next release, though expect more PRs soon :)
ref STREAM-1248