Skip to content

feat(taskbroker): port profiles consumer to taskbroker raw mode#4386

Merged
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1248-port-profiles-consumer-to-self-hosted
Jun 25, 2026
Merged

feat(taskbroker): port profiles consumer to taskbroker raw mode#4386
untitaker merged 1 commit into
masterfrom
markusunterwaditzer/stream-1248-port-profiles-consumer-to-self-hosted

Conversation

@untitaker

@untitaker untitaker commented Jun 25, 2026

Copy link
Copy Markdown
Member

Replaces the dedicated ingest-profiles consumer with taskbroker raw mode. This must be merged before the next sentry release, as the consumer code is already gone.

We're going to tear down the following consumers in sentry:

  • profiles
  • process-segments
  • all subscriptions consumers
  • ingest-replay-recordings

they're not all blocking the next release, though expect more PRs soon :)

ref STREAM-1248

Remove the dedicated ingest-profiles consumer and consume the profiles
topic via taskbroker raw passthrough mode instead. Retries and the
deadletter route onto the existing taskworker / taskworker-dlq topics.

ref STREAM-1248

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Jun 25, 2026

Copy link
Copy Markdown

STREAM-1248

@untitaker untitaker requested a review from aldy505 June 25, 2026 08:44
@untitaker untitaker enabled auto-merge (squash) June 25, 2026 08:49
@aminvakil

Copy link
Copy Markdown
Collaborator

Failing integration test is not related to this PR.

@aldy505 aldy505 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how would you scale this for high throughput ingest traffic?

@untitaker untitaker merged commit 2824d1a into master Jun 25, 2026
23 of 24 checks passed
@untitaker untitaker deleted the markusunterwaditzer/stream-1248-port-profiles-consumer-to-self-hosted branch June 25, 2026 09:14
@aminvakil

Copy link
Copy Markdown
Collaborator

Notes to myself:

This is a fix for another integration test as sentry nightly does not have / support ingest-profiles anymore.

Failing line:

ingest-profiles-1 | Error: No consumer named ingest-profiles in sentry.consumers.KAFKA_CONSUMERS.

But the unhealthy web is still present.

@untitaker

Copy link
Copy Markdown
Member Author

I wonder how would you scale this for high throughput ingest traffic?

you can horizontally scale taskworker normally. eventually it will overload taskbroker.

scaling taskbroker horizontally is a bit tricky right now (basically, you have to create a new container with its own volumes and grpc port, then point new taskworkers to it), but we're hoping to fix that too in a few months.

@untitaker

Copy link
Copy Markdown
Member Author

This is a fix for another integration test as sentry nightly does not have / support ingest-profiles anymore.

sorry about that. we were planning to delete the code after migrating self-hosted (although, not waiting for a self-hosted release) -- we only realized today that profiles was never ported in self-hosted

@aldy505

aldy505 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

This is a fix for another integration test as sentry nightly does not have / support ingest-profiles anymore.

sorry about that. we were planning to delete the code after migrating self-hosted (although, not waiting for a self-hosted release) -- we only realized today that profiles was never ported in self-hosted

oh so this was the culprit for the failing e2e tests (slack msg) all along?

@untitaker

Copy link
Copy Markdown
Member Author

re scaling, it seems we already have scaling docs. fundamentally nothing changes, only the config format. you can split out the topic into a new, separate taskbroker too if you really want (similar to namespaces)

getsentry/sentry-docs#18550

@untitaker

untitaker commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

oh so this was the culprit for the failing e2e tests (slack msg) all along?

getsentry/sentry#117912 was merged on jun 17th, so possibly. but it then got reverted and only reapplied on jun 22nd, so not sure if it explains every failure.

@aminvakil

Copy link
Copy Markdown
Collaborator

getsentry/sentry#117912 was merged on jun 17th, so possibly. but it then got reverted and only reapplied on jun 22nd, so not sure if it explains every failure.

It doesn't seem so, after merging this PR, integration test failed on this exact commit on master.

@aminvakil

Copy link
Copy Markdown
Collaborator

I think we have to give web service more time to get started and opened #4387 .

My plan is to close / open it multiple times to see if it gets passed all the times :)

@untitaker

Copy link
Copy Markdown
Member Author

i see two failures:

  • process-spans failing to start subprocesses
  • snuba-api failing to become healthy

i'm adding some debug logs for process-spans: getsentry/sentry#118444

but it's not clear to me that this is the thing that causes the integration tests to fail. it's just something i found in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants