ref(geoip): Remove geoipupdate from compose #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`geoipupdate` is not used by any other service nor it is needed for any service to run. Moreover, it is a one-shot command, causing `docker compose up --wait` to fail when it exits with a non-zero status. This happens when one has not yet set up their credentials and they may choose to never do this. This PR removes `geoipupdate` from the `docker-compose.yml` file and moves the command directly into the geoip related script. One may run this whenever they want to update their GeoIP database. This PR needs an accompanying docs change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3490 +/- ##
==========================================
- Coverage 99.03% 98.06% -0.97%
==========================================
Files 3 3
Lines 207 207
==========================================
- Hits 205 203 -2
- Misses 2 4 +2 ☔ View full report in Codecov by Sentry. |
aldy505
approved these changes
Dec 23, 2024
aldy505
approved these changes
Dec 23, 2024
|
@aldy505 I mean, we test (and support) 2.19 and 2.26 which both seem to support the flag and that's kind of all I care about 😅 |
aminvakil
approved these changes
Dec 23, 2024
hubertdeng123
approved these changes
Dec 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geoipupdateis not used by any other service nor it is needed for anyservice to run. Moreover, it is a one-shot command, causing
docker compose up --waitto fail when it exits with a non-zero status.This happens when one has not yet set up their credentials and they may
choose to never do this.
This PR removes
geoipupdatefrom thedocker-compose.ymlfile andmoves the command directly into the geoip related script. One may run
this whenever they want to update their GeoIP database.
This PR needs an accompanying docs change.
It also has the side-effect of making integration tests slightly faster (due to the initial
docker compose up --wait), and more reliable as we used to rely on the implicitdocker compose run webfrom thesentry_admintest. This also skewed the test run duration ofsentry_admintest by including the system startup time there.