fix(autofix): Retry stream from where it left off #1675
Closed
+278
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddubey
changed the title
kddubey
added a commit
that referenced
this pull request
Jan 24, 2025
[Investigation](https://github.com/getsentry/ml-models/blob/main/autofix/retry_stream/investigate_errors.ipynb) found that backoff would address almost all of the overloaded errors. Fix #1671 by retrying the completion from scratch, unlike #1675. ## How has this been tested? New unit tests and local runs described below <details> <summary>Local autofix runs</summary> Repro issue locally: 1. `git checkout main` 2. Replace all `AnthropicProvider`s with `AnthropicProviderFlaky`s in `coding/components.py`. 3. Run the Autofix coding step on a local issue, confirm you see the overloaded error and the run fails. 4. `git stash` the stuff in step 2 b/c we'll use it again when testing the fix. Test fix: 1. `git checkout kddubey/autofix/retry-stream-from-scratch` 2. `git stash pop` to replace all `AnthropicProvider`s with `AnthropicProviderFlaky`s in `coding/components.py`. 3. Run Autofix on a local issue, confirm you see the overloaded error in your logs, but it quickly tries again and finishes the run. 4. `git stash` to undo step (2) to test an unflaky API 5. Run Autofix on the same issue, confirm the run finishes fine. </summary>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1671.
Investigation found that backoff would address almost all of the overloaded errors.
Decided (see Notes at bottom of this notebook) to store the partial completion, and pass it as a new assistant message which the Anthropic API will continue generating.
Problems with this solution
Doesn't work when tools are provided. From the bottom of the test notebook:
Can result in wrong newline generation when generating markdown. I didn't see formatting errors in code though. See the "Notes" section in the test notebook.
Note: prolly doesn't gel well w/ #1650