feat(r8): Support rewriteFrames annotation in ProguardMapper
#66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Dec 1, 2025
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
Dec 4, 2025
Contributor
loewenheim
left a comment
loewenheim
left a comment
There was a problem hiding this comment.
One minor improvement that can be made, otherwise this looks good.
Member
Author
|
@loewenheim As discussed internally I implemented skipping the line completely if a rewrite rule cleared up all frames and also added a test to verify that: bb565b7 |
Contributor
|
From my perspective this is good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63
remap_stacktracewhich accepts a plain string -- we need that info to decide whether we remove inner frames or notSee linked issue for more details.