ref(server): Switches common endpoint to use Managed
#5293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/managed-envelope-endpoint
branch
2 times, most recently
from
9089678 to
b5da373
Compare
Dav1dde
force-pushed
the
dav1d/managed-envelope-endpoint
branch
from
b5da373 to
4f9f4a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step closer to replacing
ManagedEnvelopewithManaged<Envelope>.This is also a first step into improving our outcome handling in endpoints (#5288) by providing a more explicit error handling. It remains to be seen how far we can use
Rejectedfor these purposes though.Active rate limit handling has been made a bit more explicit, it was already handled in a few different ways in endpoints, this is an attempt to make it a bit more explicit. It is necessary because we require
common::handle_envelopeto returnRejected<E>, which makes the active rate limits explicitly returned on success. Callers then have to decide what to do.We may want to revisit the rate limiting behaviour of endpoints in the future again.