Skip to content

security: remove legacy publish-state-file write #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Apr 21, 2026
+8 −17
Merged

security: remove legacy publish-state-file write #7892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ jobs:
CRAFT_PUBLISH_VERSION: ${{ fromJSON(steps.inputs.outputs.result).version }}
CRAFT_PUBLISH_TARGETS_JSON: ${{ toJSON(fromJSON(steps.inputs.outputs.result).targets) }}
run: |
# Render the "already published" JSON once, reuse twice.
# Render the "already published" JSON.
payload="$(jq -n --argjson source "$CRAFT_PUBLISH_TARGETS_JSON" '[{($source[]): true }] | add | {"published": (. // {}) }')"

# Write the NEW location Craft reads from (post
# getsentry/craft#795). Craft sees cwd
# Write the state file to the safe location Craft reads from
# (getsentry/craft#797, released in 2.26.0). Craft sees cwd
# `/github/workspace/__repo__/<path>` inside the container;
# the state dir is pinned to `$GITHUB_WORKSPACE/.craft-state`
# (mapped to `/github/workspace/.craft-state` in the
Expand All @@ -217,20 +217,11 @@ jobs:
owner_sanitised="$(sanitise getsentry)"
repo_sanitised="$(sanitise "$CRAFT_PUBLISH_REPO")"
version_sanitised="$(sanitise "$CRAFT_PUBLISH_VERSION")"
new_state_dir="$GITHUB_WORKSPACE/.craft-state/craft"
new_state_file="$new_state_dir/publish-state-${owner_sanitised}-${repo_sanitised}-${cwd_hash}-${version_sanitised}.json"
mkdir -p "$new_state_dir"
printf %s "$payload" > "$new_state_file"
echo "Wrote new-location state file: $new_state_file"

# Write the LEGACY location for the duration of the rollout so
# older Craft images (before the new-location support ships)
# keep working. Remove this block after Craft is released with
# the new-location read/write and we've confirmed a few
# publish runs succeed.
legacy_state_file="__repo__/${CRAFT_PUBLISH_PATH}/.craft-publish-${CRAFT_PUBLISH_VERSION}.json"
printf %s "$payload" > "$legacy_state_file"
echo "Wrote legacy-location state file: $legacy_state_file"
state_dir="$GITHUB_WORKSPACE/.craft-state/craft"
state_file="$state_dir/publish-state-${owner_sanitised}-${repo_sanitised}-${cwd_hash}-${version_sanitised}.json"
mkdir -p "$state_dir"
printf %s "$payload" > "$state_file"
echo "Wrote state file: $state_file"

- uses: docker://getsentry/craft:latest
name: Publish using Craft
Expand Down
Loading