feat(server): Implement batch endpoint #250
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
changed the title
lcian
commented
Dec 19, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Member
Author
There was a problem hiding this comment.
Sloppy test generated by Claude.
We will replace this with e2e tests using the clients after we have client implementations of batching.
lcian
commented
Dec 19, 2025
| let mut headers = metadata.to_headers("", false).unwrap(); | ||
| headers.insert( | ||
| HEADER_BATCH_OPERATION_STATUS, | ||
| HeaderValue::from_static("200"), |
Member
Author
There was a problem hiding this comment.
This is not implemented properly.
We should proceed with https://linear.app/getsentry/issue/FS-220/improve-error-handling.
Afterwards, we can implement this and IntoResponse properly based on the error.
lcian
commented
Dec 19, 2025
| @@ -0,0 +1,134 @@ | |||
| //! Utilities to represent and serialize multipart parts. | |||
Member
Author
There was a problem hiding this comment.
The serialization has been adapted from https://crates.io/crates/multipart-stream
We might be able to get away with axum's MultipartForm instead.
lcian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a simple implementation for the batch endpoint that simply loops through the requests in batch and executes them sequentially.
This is already an improvement over having to issue multiple single-object requests, and prepares us to work on the client-side implementation of batching.
The endpoint can be changed later to issue requests in batches to the underling
StorageServiceto make this even more efficient.