-
-
Notifications
You must be signed in to change notification settings - Fork 4
feat(server): Add batch endpoint and extractor #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lcian
wants to merge
24
commits into
main
Choose a base branch
from
lcian/feat/batching-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d524a79
wip
lcian e17e474
pass around stream of inserts
lcian df0f459
wip
lcian 7f898eb
wip
lcian 5bd4a2c
wip
lcian c7f0828
wip
lcian 7331125
wip
lcian e569b7a
wip
lcian 53a1abc
wip
lcian e1dcd12
wip
lcian 01640d3
remove limits
lcian 237171f
wip
lcian 0a8f2f0
wip
lcian d5ae24f
add test
lcian 7aa0279
missing debug impls
lcian 2b14ae6
rename
lcian f958828
skill issues
lcian 941f53a
rename all lowercase
lcian 3228609
refactor to new structure
lcian 2ba690d
improve
lcian e01966b
wip
lcian ddab6cb
simplify
lcian c67fb7f
improve
lcian dbee886
lint
lcian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| use axum::Router; | ||
| use axum::http::StatusCode; | ||
| use axum::response::{IntoResponse, Response}; | ||
| use axum::routing; | ||
| use objectstore_service::id::ObjectContext; | ||
|
|
||
| use crate::auth::AuthAwareService; | ||
| use crate::endpoints::common::ApiResult; | ||
| use crate::extractors::{BatchRequest, Xt}; | ||
| use crate::state::ServiceState; | ||
|
|
||
| pub fn router() -> Router<ServiceState> { | ||
| Router::new().route("/objects:batch/{usecase}/{scopes}/", routing::post(batch)) | ||
| } | ||
|
|
||
| async fn batch( | ||
| _service: AuthAwareService, | ||
| Xt(_context): Xt<ObjectContext>, | ||
| _request: BatchRequest, | ||
| ) -> ApiResult<Response> { | ||
| Ok(StatusCode::NOT_IMPLEMENTED.into_response()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
multierover https://docs.rs/axum/latest/axum/extract/struct.Multipart.html?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I think we can use
axum::extract::Multipartdirectly now.With the old design, which included a manifest of operations as the first part, the correct content-type would've been
multipart/mixedand therefore I had to usemulter(whichaxum::extract::Multipartuses under the hood) directly becauseaxum::extract::Multipartonly works withmultipart/form-data😅.Now
multipart/form-datais correct, so we can move to usingaxum::extract::Multipartdirectly.