Skip to content

ref(tracing): Drop per-string cap on gen_ai log attributes #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obostjancic wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

ref(tracing): Drop per-string cap on gen_ai log attributes #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/junior/src/chat/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,7 +1754,6 @@ export function buildTurnFailureResponse(eventId: string): string {
// ---------------------------------------------------------------------------

const GEN_AI_DEFAULT_MAX_ATTRIBUTE_CHARS = 12_000;
const GEN_AI_MAX_STRING_CHARS = 2_000;
const GEN_AI_MAX_ARRAY_ITEMS = 50;
const GEN_AI_MAX_OBJECT_KEYS = 50;

Expand All @@ -1781,7 +1780,7 @@ function sanitizeGenAiValue(
if (shouldTreatAsBlob) {
return `[omitted:${value.length}]`;
}
return truncateGenAiString(redactSecrets(value), GEN_AI_MAX_STRING_CHARS);
return redactSecrets(value);
}

if (typeof value === "number") {
Expand Down
Loading