ref(github-code): Add edit workflow, verification, and on-behalf-of attribution#392
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ttribution Extend the github-code skill from a GitHub CLI reference into a compact repo-edit and PR workflow skill, folding in the high-value rules from code-change that were previously only in reference files. Key additions: - Core rules: instruction precedence, no-guessing guardrails, no fake check claims - Resolve target: validation path selection (scoped checks > targeted tests > full suites), baseline capture for risky work, pre-existing failure separation - Investigation: read referenced context, inspect real product context for UI/docs, know failure shape before editing bugs, re-root-cause after failed fix - Edit: keep public surfaces minimal, remove introduced duplication, solve the behavior not just the tests, compact checklist for multi-step work, pause-and-plan for non-obvious work - Verify: explicit pre-packaging validation step - Commit: on-behalf-of Co-authored-by trailers inline, footer ordering, line length - PR: draft by default, reviewer-facing prose, session link footer, Action taken on behalf of footer, handle resolution before assignment - api-surface.md: branch, status, log, diff, commit commands; default PR creation to --draft Intentionally not included: full advisor protocol (orchestration-level), diff-quality gate (separate skill), exhaustive verification harness table (conditional detail), multi-viewport screenshot protocol. Co-authored-by: David Cramer <[email protected]>
sentry-junior
Bot
force-pushed
the
jr/improve-github-code-skill
branch
from
9ad4410 to
79817ba
Compare
sentry-junior
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
github-codefrom a GitHub CLI command reference into a compact repo-edit and PR workflow skill. Folds in the high-value behavioral rules fromcode-change(junior-prod) that were previously buried in reference files the model wasn't reliably loading (see getsentry/cli#996 for the attribution miss that motivated this).On-behalf-of attribution is inline, not in references
Co-authored-bytrailers,Action taken on behalf of Full Name.footer, and session link are all in the main SKILL.md workflow steps where the model can't miss them.Investigation and verification discipline added
Read referenced context, inspect real product/UI context before inventing content, know failure shape before editing bugs, re-root-cause after failed fixes. Choose a validation path before editing (scoped checks > targeted tests > full suites). Capture baselines for risky work. Separate pre-existing failures from regressions.
Edit discipline added
Keep public surfaces minimal, remove duplication introduced by the change, solve the behavior not just the tests. Compact checklist for multi-step work. Pause-and-plan for non-obvious architecture/security/concurrency work.
Commit and PR conventions inline
type(scope): Subjectformat, footer ordering, line length, draft PRs by default, reviewer-facing prose, handle resolution before assignment.api-surface.md expanded
Added git commands for branch, status, log, diff, commit. Defaulted PR creation to
--draft.Intentionally not included
Full advisor protocol (orchestration-level, not GitHub ops),
diff-qualitygate (separate skill), exhaustive verification harness table (conditional detail better as progressive disclosure), multi-viewport screenshot protocol.Refs getsentry/cli#996
Action taken on behalf of David Cramer.
View Session in Sentry