feat(cli): scaffold .github/workflows/ci.yml in junior init#391
Merged
Conversation
Add writeGitHubWorkflow() to the init scaffolder so new Junior apps get a basic CI workflow out of the box. The workflow runs on push to main and on pull requests, installing deps, running `pnpm check` (junior check), and `pnpm build`. Closes #390 Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
actions/checkout@v6, actions/setup-node@v6, pnpm/action-setup@v6 Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
pnpm/action-setup requires either a version input or a packageManager field in package.json. Without it, CI fails on first run. Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 284c0e8. Configure here.
corepack rejects bare major versions like 'pnpm@10' — it requires exact semver. Use '[email protected]' as the scaffold baseline; users can run 'corepack use pnpm@latest' to update. Add regression test asserting packageManager matches exact semver. Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
Scaffolded projects don't actively maintain a packageManager pin, so it goes stale immediately. Instead, let pnpm/action-setup resolve the latest pnpm 10.x via its version input. Users who want corepack pinning can add packageManager themselves when ready. Co-Authored-By: Claude (anthropic/claude-opus-4.6) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
junior initnow scaffolds a.github/workflows/ci.ymlso new Junior apps ship with CI validation out of the box.Scaffolded Workflow
The generated workflow runs on push to
mainand on pull requests with steps: checkout, pnpm 10 setup, Node 24,pnpm install --frozen-lockfile,pnpm check(validates skills, plugins, and app structure), andpnpm build.pnpm versioning
pnpm version is declared via
pnpm/action-setup'sversion: 10input rather than apackageManagerfield inpackage.json. Scaffolded projects don't actively maintain a version pin, sopackageManagerwould go stale immediately. Users who want corepack pinning can add it themselves when ready.Fixes #390