Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Use the active Sentry SDK DSN to build Explore links for Slack footer conversation IDs. This points reviewers and operators at the telemetry project that receives Junior spans instead of using provider configuration meant for user-facing Sentry queries. Co-Authored-By: GPT-5 Codex <codex@openai.com>
dcramer
force-pushed
the
feature/slack-footer-sentry-link
branch
from
d46c990 to
8965643
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8965643. Configure here.
| return String(value); | ||
| } | ||
| return typeof value === "string" && value.trim() ? value.trim() : undefined; | ||
| } |
There was a problem hiding this comment.
Same-named function with different semantics risks silent breakage
Low Severity
A private toOptionalString is introduced in footer.ts that shares its name with the exported toOptionalString in coerce.ts, but their behavior diverges: the footer version handles number inputs (converting them via String()) and trims returned strings, while the coerce version only accepts strings and returns them untrimmed. If a maintainer later consolidates by importing from coerce.ts, numeric orgId values from the Sentry SDK would silently become undefined, breaking link generation.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 8965643. Configure here.
1 participant
Link finalized Slack footer conversation IDs to Sentry Explore when Junior telemetry has an active SDK DSN. The footer keeps the same compact context styling, but the ID now opens a project-scoped search for
gen_ai.conversation.idin the Sentry project receiving Junior spans.Footer-owned Link Rendering
The Slack footer helper now derives the Sentry URL directly from the active Sentry SDK client DSN while building the ID item. Delivery call sites keep passing only structured footer diagnostics, so they do not need to know about Sentry URL construction.
Minimal Explore URL
The generated link includes only the conversation search query, DSN project ID, and a 14-day time window. If the SDK cannot expose an organization target, the footer leaves the ID as plain text.