Skip to content

fix: clone sentryConfig before mutation #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaKGoldberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: clone sentryConfig before mutation #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion createEnvironment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ function createEnvironment({baseEnvironment} = {}) {

const [config, context] = args;

this.options = config.projectConfig.testEnvironmentOptions?.sentryConfig;
this.options = structuredClone(config.projectConfig.testEnvironmentOptions?.sentryConfig)

@cursor cursor Bot Mar 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structuredClone throws on configs containing functions

Medium Severity

structuredClone throws a DataCloneError if the sentryConfig object (or its nested init property) contains any function values. Sentry's init options commonly include callbacks like beforeSend, tracesSampler, beforeBreadcrumb, or integrations as a function. Users passing any of these will now get a runtime error that didn't exist before this change. A shallow spread of only the mutated paths (init and init.integrations) would avoid this while still preventing the shared-config mutation the PR intends to fix.

Fix in Cursor Fix in Web


if (
!this.options ||
Expand Down
Loading