Skip to content

fix: add GNU stack note to crashpad_info_note.S #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 2 commits into from
Nov 12, 2025
Merged

fix: add GNU stack note to crashpad_info_note.S #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c2ae3c
fix: add GNU-stack note to crashpad_info_note.S
supervacuus Nov 11, 2025
a64405e
bump lower-end GCC to 10.5.0 on Ubuntu 22.04
supervacuus Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
platform: ubuntu-22.04
CC: gcc
CXX: g++
- name: Ubuntu (GCC 9.5.0)
- name: Ubuntu (GCC 10.5.0)
platform: ubuntu-22.04
CC: gcc-9
CXX: g++-9
CC: gcc-10
CXX: g++-10
- name: Ubuntu (clang 18.1.3)
platform: ubuntu-24.04
CC: clang
Expand Down
1 change: 1 addition & 0 deletions client/crashpad_info_note.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,4 @@ CRASHPAD_NOTE_REFERENCE:
// linking Crashpad. The subtraction from |name| is a convenience to allow the
// value to be computed statically.
.quad name - CRASHPAD_NOTE
.section .note.GNU-stack,"",@progbits