Skip to content

fix: hide the Objective-C ARC compile options in the interface library #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 1 commit into from
Sep 18, 2025
Merged

fix: hide the Objective-C ARC compile options in the interface library #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@ if(LINUX)
)
endif()

if(APPLE)
target_compile_options(crashpad_interface INTERFACE
"-fobjc-arc"
"-fno-objc-arc-exceptions"
"-Wno-deprecated-declarations"
)
endif()

add_library(crashpad::interface ALIAS crashpad_interface)

add_subdirectory(compat)
Expand Down
6 changes: 0 additions & 6 deletions third_party/mini_chromium/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,6 @@ else()
)
endif()

if(APPLE)
target_compile_options(mini_chromium
PUBLIC "-fobjc-arc" "-fno-objc-arc-exceptions"
PRIVATE "-Wno-deprecated-declarations"
)
endif()
if(APPLE AND NOT IOS)
target_link_libraries(mini_chromium PUBLIC
"-framework ApplicationServices"
Expand Down
2 changes: 0 additions & 2 deletions util/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,8 +529,6 @@ if(APPLE)
"-framework UIKit"
)
endif()

target_compile_options(crashpad_util PRIVATE "-Wno-deprecated-declarations")
endif()

if(LINUX)
Expand Down
Loading