Skip to content

feat: windows binary versioning #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 1 commit into from
Nov 12, 2024
Merged

feat: windows binary versioning #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions handler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ if(NOT IOS)
if(MSVC)
target_link_options(crashpad_handler PRIVATE "/SUBSYSTEM:WINDOWS")
endif()

if (COMMAND sentry_add_version_resource)
sentry_add_version_resource(crashpad_handler "Crashpad Handler")
endif()
endif()

set_property(TARGET crashpad_handler PROPERTY EXPORT_NAME crashpad_handler)
Expand Down Expand Up @@ -144,6 +148,10 @@ if (WIN32)
set_property(TARGET crashpad_wer PROPERTY PREFIX "") # ensure MINGW doesn't prefix "lib" to dll name
add_library(crashpad::wer ALIAS crashpad_wer)

if (COMMAND sentry_add_version_resource)
sentry_add_version_resource(crashpad_wer "Crashpad WER Module")
endif()

install(TARGETS crashpad_wer EXPORT crashpad_export
RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}"
)
Expand Down