getsentry · jan-auer · Nov 7, 2023 · Nov 7, 2023 · Nov 22, 2023 · Nov 23, 2023
diff --git a/.clang-format b/.clang-format
@@ -1,4 +1,4 @@
-# Copyright 2014 The Crashpad Authors. All rights reserved.
+# Copyright 2014 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

diff --git a/.gitattributes b/.gitattributes
@@ -1,4 +1,4 @@
-# Copyright 2019 The Crashpad Authors. All rights reserved.
+# Copyright 2019 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -23,8 +23,6 @@
 *.gn text eol=lf
 *.gni text eol=lf
 *.go text eol=lf
-*.gyp text eol=lf
-*.gypi text eol=lf
 *.h text eol=lf
 *.m text eol=lf
 *.md text eol=lf

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1 @@
+*   @getsentry/processing
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -0,0 +1,127 @@
+name: Build
+
+on:
+  push:
+    branches:
+      - getsentry
+  pull_request:
+
+jobs:
+  build:
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: Ubuntu (GCC 14.2.0)
+            platform: ubuntu-24.04
+            CC: gcc-14
+            CXX: g++-14
+          - name: Ubuntu (GCC 13.3.0)
+            platform: ubuntu-24.04
+            CC: gcc
+            CXX: g++
+          - name: Ubuntu (GCC 11.4.0)
+            platform: ubuntu-22.04
+            CC: gcc
+            CXX: g++
+          - name: Ubuntu (GCC 10.5.0)
+            platform: ubuntu-22.04
+            CC: gcc-10
+            CXX: g++-10
+          - name: Ubuntu (clang 18.1.3)
+            platform: ubuntu-24.04
+            CC: clang
+            CXX: clang++
+          - name: Ubuntu (clang 14.0.0)
+            platform: ubuntu-22.04
+            CC: clang
+            CXX: clang++
+          - name: Alpine Linux (GCC + musl)
+            platform: ubuntu-latest
+            container: alpine:3.21
+            CC: gcc
+            CXX: g++
+          - name: Alpine Linux (clang + musl)
+            platform: ubuntu-latest
+            container: alpine:3.21
+            CC: clang
+            CXX: clang++
+          - name: Windows (x64)
+            platform: windows-latest
+          - name: Windows ClangCL (x64)
+            platform: windows-latest
+            CMAKE_DEFINES: -G 'Visual Studio 17 2022' -A x64 -T ClangCL
+          - name: Windows (arm64)
+            platform: windows-latest
+            CMAKE_DEFINES: -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/win_arm64.cmake -A arm64
+          - name: LLVM-MINGW (x64)
+            platform: windows-latest
+            MINGW: 1
+            MINGW_PKG_PREFIX: x86_64-w64-mingw32
+            MINGW_ASM_MASM_COMPILER: "'llvm-ml;-m64'"
+            CMAKE_DEFINES: -DCRASHPAD_ZLIB_SYSTEM=OFF -DCRASHPAD_BUILD_TOOLS=OFF -G Ninja
+          - name: LLVM-MINGW (arm64)
+            platform: windows-latest
+            MINGW: 1
+            MINGW_PKG_PREFIX: aarch64-w64-mingw32
+            CMAKE_DEFINES: -DCRASHPAD_ZLIB_SYSTEM=OFF -DCRASHPAD_BUILD_TOOLS=OFF -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/mingw_arm64.cmake -G Ninja
+          - name: macOS
+            platform: macos-latest
+    name: ${{ matrix.name }}
+    runs-on: ${{ matrix.platform }}
+    container: ${{ matrix.container }}
+    env:
+      CMAKE_DEFINES: "${{ matrix.CMAKE_DEFINES }}"
+    steps:
+      - name: Installing Alpine Linux Dependencies
+        if: ${{ contains(matrix.container, 'alpine') }}
+        run: |
+          apk update
+          apk add git bash build-base clang cmake zlib-dev curl-dev openssl-dev libunwind-dev linux-headers pkgconf
+
+      - uses: actions/checkout@v4
+        with:
+          submodules: "recursive"
+
+      - name: Installing Ubuntu Dependencies
+        if: ${{ runner.os == 'Linux' && !matrix.container }}
+        run: |
+          sudo apt update
+          sudo apt install clang zlib1g-dev libcurl4-openssl-dev libssl-dev libunwind-dev pkg-config
+
+      - name: Installing LLVM-MINGW Dependencies
+        if: ${{ runner.os == 'Windows' && matrix.MINGW == '1' }}
+        shell: powershell
+        env:
+          MINGW_PKG_PREFIX: ${{ matrix.MINGW_PKG_PREFIX }}
+          MINGW_ASM_MASM_COMPILER: ${{ matrix.MINGW_ASM_MASM_COMPILER }}
+        run: . "cmake\scripts\install-llvm-mingw.ps1"
+
+      - name: Build crashpad
+        shell: bash
+        run: |
+          [ "${{ matrix.CC }}" ] && export CC="${{ matrix.CC }}"
+          [ "${{ matrix.CXX }}" ] && export CXX="${{ matrix.CXX }}"
+          echo "CMAKE_DEFINES=${CMAKE_DEFINES}"
+          eval "cmake -B cmake-build -D CRASHPAD_BUILD_TOOLS=On $CMAKE_DEFINES"
+          cmake --build cmake-build --parallel
+
+      - name: Build crashpad with client-side stack traces
+        shell: bash
+        run: |
+          [ "${{ matrix.CC }}" ] && export CC="${{ matrix.CC }}"
+          [ "${{ matrix.CXX }}" ] && export CXX="${{ matrix.CXX }}"
+          echo "CMAKE_DEFINES=${CMAKE_DEFINES}"
+          eval "cmake -B cmake-build-stacks -D CRASHPAD_ENABLE_STACKTRACE=ON $CMAKE_DEFINES"
+          cmake --build cmake-build-stacks --parallel
+
+  build-ios:
+    name: 'iOS'
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: "recursive"
+      - run: |
+          cmake -B crashpad-xcode -GXcode -DCMAKE_SYSTEM_NAME=iOS
+          xcodebuild build -project crashpad-xcode/crashpad.xcodeproj
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,4 @@
-# Copyright 2014 The Crashpad Authors. All rights reserved.
+# Copyright 2014 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -12,20 +12,25 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+# Keep sorted
+
 *.Makefile
 *.ninja
 *.pyc
 *.target.mk
 *.xcodeproj
 *~
 .*.sw?
-.cache
 .DS_Store
+.cache
 .gdb_history
 .gdbinit
+/.vscode/
 /Makefile
+/build/fuchsia
 /out
 /third_party/edo/edo
+/third_party/fuchsia-gn-sdk
 /third_party/fuchsia/.cipd
 /third_party/fuchsia/clang
 /third_party/fuchsia/qemu
@@ -36,8 +41,11 @@
 /third_party/linux/clang
 /third_party/linux/sysroot
 /third_party/lss/lss
-/third_party/gyp/gyp
 /third_party/mini_chromium/mini_chromium
+/third_party/ninja/linux
+/third_party/ninja/mac*
+/third_party/ninja/ninja.exe
+/third_party/windows/clang/win-amd64
 /third_party/zlib/zlib
 /xcodebuild
 tags
diff --git a/.gitmodules b/.gitmodules
@@ -0,0 +1,9 @@
+[submodule "third_party/mini_chromium/mini_chromium"]
+	path = third_party/mini_chromium/mini_chromium
+	url = https://github.com/getsentry/mini_chromium.git
+[submodule "third_party/zlib/zlib"]
+	path = third_party/zlib/zlib
+	url = https://chromium.googlesource.com/chromium/src/third_party/zlib
+[submodule "third_party/lss/lss"]
+	path = third_party/lss/lss
+	url = https://chromium.googlesource.com/linux-syscall-support
diff --git a/.gn b/.gn
@@ -1,4 +1,4 @@
-# Copyright 2017 The Crashpad Authors. All rights reserved.
+# Copyright 2017 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -13,3 +13,4 @@
 # limitations under the License.
 
 buildconfig = "//build/BUILDCONFIG.gn"
+script_executable = "python3"
diff --git a/.style.yapf b/.style.yapf
@@ -1,4 +1,4 @@
-# Copyright 2020 The Crashpad Authors. All rights reserved.
+# Copyright 2020 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.

diff --git a/.vpython → .vpython3 b/.vpython → .vpython3
@@ -1,4 +1,4 @@
-# Copyright 2018 The Crashpad Authors. All rights reserved.
+# Copyright 2022 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -21,8 +21,8 @@
 
 # This is needed for snapshot/win/end_to_end_test.py.
 wheel: <
-  name: "infra/python/wheels/pypiwin32/${vpython_platform}"
-  version: "version:219"
+  name: "infra/python/wheels/pywin32/${vpython_platform}"
+  version: "version:300"
   match_tag: <
     platform: "win32"
   >

diff --git a/AUTHORS b/AUTHORS
@@ -12,3 +12,5 @@ Opera Software ASA
 Vewd Software AS
 LG Electronics, Inc.
 MIPS Technologies, Inc.
+Darshan Sen <[email protected]>
+Ho Cheung <[email protected]>
diff --git a/BUILD.gn b/BUILD.gn
@@ -1,4 +1,4 @@
-# Copyright 2017 The Crashpad Authors. All rights reserved.
+# Copyright 2017 The Crashpad Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -17,7 +17,10 @@ import("build/test.gni")
 import("util/net/tls.gni")
 
 config("crashpad_config") {
-  include_dirs = [ "." ]
+  include_dirs = [
+    ".",
+    root_gen_dir,
+  ]
 }
 
 if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
@@ -30,16 +33,37 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
       "test:test_test",
       "util:util_test",
     ]
+
+    data_deps = []
+
+    if (crashpad_is_in_chromium) {
+      data_deps += [ "//testing/buildbot/filters:crashpad_tests_filters" ]
+    }
+
     if (!crashpad_is_ios && !crashpad_is_fuchsia) {
       deps += [ "handler:handler_test" ]
     }
     if (crashpad_is_in_fuchsia) {
       # TODO(fuchsia:46559): Fix the leaks and remove this.
       deps += [ "//build/config/sanitizers:suppress-lsan.DO-NOT-USE-THIS" ]
+
+      # TODO(fxbug.dev/42059784): Remove this once the underlying issue is
+      # addressed.
+      exclude_toolchain_tags = [ "hwasan" ]
     }
     if (crashpad_is_android) {
       use_raw_android_executable = true
 
+      # crbug.com/418874703 - This is a workaround to propagate the data deps to
+      # //:crashpad_tests__dist for Android build.
+      data_deps += [
+        "snapshot:crashpad_snapshot_test_both_dt_hash_styles",
+        "snapshot:crashpad_snapshot_test_module",
+        "snapshot:crashpad_snapshot_test_module_large",
+        "snapshot:crashpad_snapshot_test_module_small",
+        "test:crashpad_test_test_multiprocess_exec_test_child",
+      ]
+
       copy("crashpad_test_data") {
         testonly = true
         sources = [
@@ -64,7 +88,7 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
   if (crashpad_is_in_fuchsia) {
     import("//build/components.gni")
     fuchsia_test_component("crashpad-test-component") {
-      manifest = "test/fuchsia_crashpad_tests.cmx"
+      manifest = "test/fuchsia_crashpad_tests.cml"
       deps = [
         ":crashpad-test-resources",
         ":crashpad_tests",
@@ -81,8 +105,8 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
       test_components = [ ":crashpad-test-component" ]
 
       deps = [
-        "//src/connectivity/network/dns:component-legacy",
-        "//src/connectivity/network/netstack:component-legacy",
+        "//src/connectivity/network/dns:component",
+        "//src/connectivity/network/netstack:component",
       ]
 
       test_specs = {
@@ -118,11 +142,6 @@ if (crashpad_is_in_chromium || crashpad_is_in_fuchsia) {
       deps = _resources
     }
 
-    fuchsia_shell_package("crashpad-database-util") {
-      package_name = "crashpad_database_util"
-      deps = [ "tools:crashpad_database_util" ]
-    }
-
     group("tests") {
       testonly = true