Skip to content

fix(action): Resolve major tag to matching binary - #889

Merged
BYK merged 1 commit into
masterfrom
fix/action-major-tag
Oct 2, 2026
Merged

BYK merged 1 commit into
masterfrom
fix/action-major-tag

Conversation

@BYK

@BYK BYK commented Oct 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Resolve moving action refs such as getsentry/craft@v2 to the release version recorded in that action revision’s package.json. The current v2 ref points to 2.33.0, but no GitHub release named v2 exists, so the action previously downloaded the latest release instead.
  • Fail closed if the major tag points to a prerelease or different major, or if the matching release asset is missing. Keep explicit craft_version and latest support.

Validation

  • A regression failed before the fix. Focused action tests: 37 passed. Full Vitest: 1,242 passed, 1 skipped across 62 files.
  • Typecheck, lint (0 errors, 7 existing warnings), format, build, and shell syntax checks passed.
  • Verified v2 and 2.33.0 tags point to the same release commit and v2 contains package version 2.33.0.

Co-Authored-By: GPT-6 Sol (OpenAI) <agent@openai.com>
@BYK
BYK merged commit 9c8a8ef into master Oct 2, 2026
22 checks passed
@BYK
BYK deleted the fix/action-major-tag branch October 2, 2026 16:47

This branch was successfully deployed

1 active deployment
false — 14c67e3b Deployed Oct 2, 2026 by BYK via Build #2962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant