Skip to content

fix(publish): Clean up release branches for revisions - #884

Merged
BYK merged 1 commit into
masterfrom
fix/cleanup-release-branch
Sep 29, 2026
Merged

BYK merged 1 commit into
masterfrom
fix/cleanup-release-branch

Conversation

@BYK

@BYK BYK commented Sep 28, 2026

Copy link
Copy Markdown
Member

Summary

  • keep the requested publish revision separate from the canonical release branch name
  • delete remote release branches only when their tip matches the published revision, then safely remove matching local branches
  • report cleanup failures separately from merge failures
  • cover revision publishing, ordinary branch publishing, and remote/local branch races with unit and real-Git regressions

Validation

  • pnpm typecheck
  • pnpm lint (0 errors; 7 existing warnings)
  • pnpm format:check
  • pnpm test -- --printConsoleTrace (1,221 passed, 1 skipped)
  • pnpm build
  • git diff --check

Fixes #878

@BYK

BYK commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

@jpnurmi - wdyt, do you think this fixes your issue?

@jpnurmi jpnurmi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! 👍

@BYK
BYK merged commit 47e3f18 into master Sep 29, 2026
22 checks passed
@BYK
BYK deleted the fix/cleanup-release-branch branch September 29, 2026 15:46

This branch was successfully deployed

1 active deployment
false — 5a9d156f Deployed Sep 28, 2026 by BYK via Build #2945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish --rev fails to delete merged release branches

3 participants