forked from google/breakpad
-
Notifications
You must be signed in to change notification settings - Fork 13
chore(readme): Add README.getsentry.md for Sentry modifications to Breakpad
#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c06b723
Add README for Sentry modifications to Breakpad
JoshuaMoelans a3b46e6
Update README with Sentry modifications link
JoshuaMoelans 006d92d
update
JoshuaMoelans db7e372
clean up sentry readme
JoshuaMoelans e123849
Add macOS handler callback modification bullet point
JoshuaMoelans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Sentry Modifications | ||
|
|
||
| This is a fork of [Google Breakpad](https://chromium.googlesource.com/breakpad/breakpad/) maintained by Sentry for use in `sentry-native`. | ||
|
|
||
| ## Modifications | ||
|
|
||
| - **Windows**: Dynamically size minidump paths instead of using `MAX_PATH` constant | ||
| - **Windows**: Xbox One build support | ||
| - **Linux**: Cast `SIGSTKSZ` to int for compatibility with glibc 2.34+ (where it's no longer a compile-time constant) | ||
| - **Build System**: CMake integration (see below) | ||
| - **C++17 standard requirement**: upstream uses C++20 (or newer). | ||
|
|
||
| ## Build System Changes | ||
|
|
||
| To minimize external dependencies and better integrate with `sentry-native`, this fork uses CMake instead of Breakpad's native Autotools/`configure` build system. | ||
|
|
||
| The CMake build files are maintained in the parent [`sentry-native` repository](https://github.com/getsentry/sentry-native): | ||
|
|
||
| - [`../../CMakeLists.txt`](https://github.com/getsentry/sentry-native/blob/master/CMakeLists.txt) - Defines the `breakpad_client` target and lists all source files | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,3 +80,8 @@ dependent repos are up-to-date. | |
| click on it, then “Add reviewer”, and enter in the code reviewer. Depending | ||
| on your settings, you may not see an email, but the reviewer has been | ||
| notified with [email protected] always CC’d. | ||
|
|
||
| ## Sentry modifications | ||
|
|
||
| See [README.getsentry.md](README.getsentry.md) for more information on the | ||
| changes, and on maintaining the fork. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.