Skip to content

fix(win): dynamically size minidump_path in handler instead of using … #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 2 commits into from
Oct 20, 2025
Merged

fix(win): dynamically size minidump_path in handler instead of using … #43

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf176be
fix(win): dynamically size minidump_path in handler instead of using …
supervacuus Oct 17, 2025
1223135
reset next_minidump_path_[c_] if swprintf fails
supervacuus Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/client/windows/handler/exception_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,14 +1049,23 @@ void ExceptionHandler::UpdateNextID() {
next_minidump_id_ = GUIDString::GUIDToWString(&id);
next_minidump_id_c_ = next_minidump_id_.c_str();

wchar_t minidump_path[MAX_PATH];
swprintf(minidump_path, MAX_PATH, L"%s\\%s.dmp",
dump_path_c_, next_minidump_id_c_);
const size_t dump_path_c_len = wcslen(dump_path_c_);
const size_t next_minidump_id_c_len = wcslen(next_minidump_id_c_);
// 1 for backslash + 4 for ".dmp" + 1 for NUL
const size_t minidump_path_len =
dump_path_c_len + 1 + next_minidump_id_c_len + 4 + 1;
std::vector<wchar_t> minidump_path(minidump_path_len);
const int written =
swprintf(minidump_path.data(), minidump_path_len, L"%s\\%s.dmp",
dump_path_c_, next_minidump_id_c_);
if (written < 0 || static_cast<size_t>(written) >= minidump_path.size()) {
return;
}

// remove when VC++7.1 is no longer supported
minidump_path[MAX_PATH - 1] = L'\0';
minidump_path.back() = L'\0';

next_minidump_path_ = minidump_path;
next_minidump_path_.assign(minidump_path.data());
next_minidump_path_c_ = next_minidump_path_.c_str();
}

Expand Down