Merge pull request #48 from getpingback/fix/variable-input

Fix/variable input
getpingback · Dec 5, 2024 · 60a477a · 60a477a
2 parents eac0689 + 13aaf40
commit 60a477a
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,27 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [0.0.279](https://github.com/getpingback/ui/compare/v0.0.276...v0.0.279) (2024-12-04)
+
+
+### Bug Fixes
+
+* onVariablesEndReached ([e68bacf](https://github.com/getpingback/ui/commits/e68bacf78b152eb94ffa2e3e51dbee7cbb571808))
+
+### [0.0.278](https://github.com/getpingback/ui/compare/v0.0.276...v0.0.278) (2024-12-04)
+
+
+### Bug Fixes
+
+* onVariablesEndReached ([e68bacf](https://github.com/getpingback/ui/commits/e68bacf78b152eb94ffa2e3e51dbee7cbb571808))
+
+### [0.0.277](https://github.com/getpingback/ui/compare/v0.0.276...v0.0.277) (2024-12-04)
+
+
+### Bug Fixes
+
+* onVariablesEndReached ([e68bacf](https://github.com/getpingback/ui/commits/e68bacf78b152eb94ffa2e3e51dbee7cbb571808))
+
 ### [0.0.275](https://github.com/getpingback/ui/compare/v0.0.274...v0.0.275) (2024-12-03)
 
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@getpingback/ui",
   "author": "Pingback Team",
-  "version": "0.0.276",
+  "version": "0.0.280",
   "license": "MIT",
   "main": "dist/cjs/index.js",
   "module": "dist/esm/index.js",

diff --git a/src/components/variable-input/variable-input.stories.tsx b/src/components/variable-input/variable-input.stories.tsx
@@ -26,13 +26,20 @@ const options = [
   },
   {
     heading: 'Custom Variables',
-    items: [{ label: 'Custom Variable', value: 'customVariable' }]
+    items: [
+      { label: 'Custom Variable', value: 'customVariable' },
+      { label: 'Custom Variable 2', value: 'customVariable2' },
+      { label: 'Custom Variable 3', value: 'customVariable3' },
+      { label: 'Custom Variable 4', value: 'customVariable4' },
+      { label: 'Custom Variable 5', value: 'customVariable5' }
+    ]
   }
 ];
 
 export const Default: Story = {
   args: {
-    options
+    options,
+    onVariablesEndReached: () => console.log('End Reached')
   }
 };
 

diff --git a/src/components/variable-input/variable-input.tsx b/src/components/variable-input/variable-input.tsx
@@ -225,10 +225,7 @@ export function VariableInput({
   }, [isFocused, text, placeholder, initialContent]);
 
   React.useEffect(() => {
-    if (!open) {
-      onVariablesEndReached?.();
-      return;
-    }
+    if (!open) return;
 
     let observer: IntersectionObserver;
     setTimeout(() => {