Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Correct type #66

Merged
merged 1 commit into from
Apr 21, 2023
Merged

utils: Correct type #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion git_pw/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def echo_via_pager(
_echo_via_pager(pager, out)
return

pager = git_config('core.parser')
pager = git_config('core.pager')
if pager:
_echo_via_pager(pager, out)
return
Expand Down
6 changes: 3 additions & 3 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_echo_via_pager_env_GIT_PAGER(mock_inner, mock_tabulate, mock_config):
def test_echo_via_pager_config(mock_inner, mock_tabulate, mock_config):
utils.echo_via_pager('test', ('foo',), None)

mock_config.assert_called_once_with('core.parser')
mock_config.assert_called_once_with('core.pager')
mock_tabulate.assert_called_once_with('test', ('foo',), None)
mock_inner.assert_called_once_with('bar', mock_tabulate.return_value)

Expand All @@ -72,7 +72,7 @@ def test_echo_via_pager_config(mock_inner, mock_tabulate, mock_config):
def test_echo_via_pager_env_PAGER(mock_inner, mock_tabulate, mock_config):
utils.echo_via_pager('test', ('foo',), None)

mock_config.assert_called_once_with('core.parser')
mock_config.assert_called_once_with('core.pager')
mock_tabulate.assert_called_once_with('test', ('foo',), None)
mock_inner.assert_called_once_with('baz', mock_tabulate.return_value)

Expand All @@ -84,7 +84,7 @@ def test_echo_via_pager_env_PAGER(mock_inner, mock_tabulate, mock_config):
def test_echo_via_pager_env_default(mock_inner, mock_tabulate, mock_config):
utils.echo_via_pager('test', ('foo',), None)

mock_config.assert_called_once_with('core.parser')
mock_config.assert_called_once_with('core.pager')
mock_tabulate.assert_called_once_with('test', ('foo',), None)
mock_inner.assert_called_once_with('less', mock_tabulate.return_value)

Expand Down