Archive finished subagents across the whole track

[boudra]

Linked issue

None. Related provider-row persistence work: Refs #3137.

Type of change

• Bug fix
• New feature
• Enhancement
• Refactor
• Docs

Reasoning

Archive finished previously dismissed only finished provider-owned rows, despite presenting managed Paseo subagents in the same track. Users had to archive finished managed children one at a time, so the bulk action did not match the surface it belonged to.

This change makes the action cover every finished row. Managed children archive sequentially through the existing optimistic lifecycle mutation; provider-owned children remain a client-local dismissal. The workflow and retry state live in a non-React controller so the UI only subscribes, renders status, and dispatches the action.

Goals

• Archive idle or errored managed subagents from the track's bulk action.
• Dismiss completed, failed, or canceled provider-owned subagents in the same action.
• Keep running, initializing, resumed, detached, archived, and reparented managed children safe.
• Show stable progress while archiving and a retryable failure state for children that remain eligible.
• Preserve provider descriptors, timelines, open tabs, and resumed-child visibility.
• Return complete per-child archive, dismissal, skip, and failure outcomes from the operation boundary.

Non-goals

• Add a bulk daemon RPC or change the protocol.
• Delete provider-owned sessions or persist their hidden state across app restarts.
• Change individual archive, detach, or tab behavior.
• Redesign the subagent track or shared status presentation.

QA

Automated behavior coverage:

• npx vitest run against the four focused subagent files — 59 tests passed.
• Targeted real browser/daemon regression — 2 tests passed.
  • Holds the real archive request to prove optimistic removal, disabled state, and stable progress before daemon completion.
  • Injects one correlated RPC rejection to prove row rollback, visible retry, and successful recovery through the real daemon.
• Pre-commit npm run format:check:files — passed.
• Pre-commit npm run lint — 0 warnings, 0 errors.
• Pre-commit npm run typecheck — all workspaces passed.
• git diff --check — passed.

Platform coverage:

Platform	Coverage
Web / desktop browser	Real browser and isolated daemon E2E
Electron desktop	Shared web UI path; not manually exercised
iOS	Not manually exercised
Android	Not manually exercised

The visible change is limited to transient numeric progress and localized retry copy in the existing track header; no layout or status-icon design changed.

Risk surface

The main risk is lifecycle coordination during partial failure. The controller rechecks each managed child before archive and classifies retryability from the authoritative store after rejection. Tests cover optimistic removal, sequential settlement, mixed managed/provider rows, resumed work, missing/archived/reparented children, partial failure, and retry recovery.

Checklist

• One focused change
• npm run typecheck passes
• npm run lint passes
• npm run format passes
• QA evidence
• Tests added or updated where it made sense

[greptile-apps]

Greptile Summary

The PR extends the track-level archive action to process both managed and provider-owned finished subagents.

• Archives eligible managed children sequentially with progress and retry state.
• Continues dismissing finished provider-owned rows locally.
• Adds focused controller, presentation, translation, unit, and real-browser coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
packages/app/src/subagents/archive-finished.ts	Introduces the sequential archive controller, eligibility checks, progress reporting, outcome classification, and retry-state reconciliation.
packages/app/src/subagents/use-archive-finished.ts	Connects the controller to authoritative session state, the existing archive mutation, and provider-row dismissal.
packages/app/src/subagents/track.tsx	Renders archive progress and retry status while preventing duplicate submissions.
packages/app/e2e/browser/archive-finished-subagents.spec.ts	Covers optimistic managed-child removal, daemon settlement, rollback, visible retry state, and recovery through a real browser and daemon.
packages/app/e2e/support/helpers/subagents.ts	Encapsulates archive synchronization, daemon rejection, and authoritative archive-state assertions behind domain-level E2E helpers.

Sequence Diagram

sequenceDiagram
  participant U as User
  participant T as Subagent track
  participant C as Archive controller
  participant P as Provider store
  participant D as Daemon
  U->>T: Archive finished
  T->>C: archiveFinished()
  C->>P: Hide finished provider rows
  loop Each eligible managed child
    C->>D: Archive child
    D-->>C: Success or failure
    C-->>T: Update progress
  end
  C-->>T: Idle or retryable failure state

Loading

_{Reviews (2): Last reviewed commit: "test(app): clarify subagent archive asse..." | Re-trigger Greptile}