Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/app/e2e/browser/settings-navigation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,13 @@ test.describe("Settings sidebar navigation", () => {
await clickSettingsBackToWorkspace(page);
await expect(page).not.toHaveURL(/\/settings(\/|$)/);
});

test("pressing Escape closes settings", async ({ page }) => {
await gotoAppShell(page);
await openSettings(page);
await page.keyboard.press("Escape");
await expect(page).not.toHaveURL(/\/settings(\/|$)/);
});
});

test.describe("Settings — compact master-detail", () => {
Expand Down
16 changes: 15 additions & 1 deletion packages/app/src/hooks/use-keyboard-shortcuts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import { isNative } from "@/constants/platform";
import { keyboardShortcutsAvailable } from "@/keyboard/availability";
import { getDesktopHost, isElectronRuntime } from "@/desktop/host";
import { isImeComposingKeyboardEvent } from "@/utils/keyboard-ime";
import { buildOpenProjectRoute } from "@/utils/host-routes";
import { hasActiveWebOverlay } from "@/lib/overlay-root";
import {
type ActiveWorkspaceSelection,
navigateToLastWorkspace,
Expand Down Expand Up @@ -177,7 +179,11 @@ export function useKeyboardShortcuts({
navigateToWorkspace({ serverId: action.serverId, workspaceId: action.workspaceId });
return true;
case "navigate-last-workspace":
return navigateToLastWorkspace();
if (navigateToLastWorkspace()) {
return true;
}
router.replace(buildOpenProjectRoute());
return true;
case "router-replace":
router.replace(action.route as Parameters<typeof router.replace>[0]);
return true;
Expand Down Expand Up @@ -325,6 +331,14 @@ export function useKeyboardShortcuts({
}

const key = event.key ?? "";
if (
key === "Escape" &&
pathname.startsWith("/settings") &&
!isMobile &&
hasActiveWebOverlay()
) {
return;
}
if (key === badgeModifierKey && !event.shiftKey) {
setBadgeModifierDown(true);
}
Expand Down
21 changes: 21 additions & 0 deletions packages/app/src/keyboard/route-shortcut.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,27 @@ describe("routeKeyboardShortcut — dispatch passthroughs", () => {
action: expected,
});
});

it("closes desktop settings when Escape routes through agent interrupt", () => {
expect(
routeKeyboardShortcut(
{ action: "agent.interrupt", payload: null },
makeCtx({ pathname: "/settings/general" }),
),
).toEqual<ShortcutAction>({ kind: "navigate-last-workspace" });
});

it("keeps agent interrupt behavior on compact settings layouts", () => {
expect(
routeKeyboardShortcut(
{ action: "agent.interrupt", payload: null },
makeCtx({ pathname: "/settings/general", isMobile: true }),
),
).toEqual<ShortcutAction>({
kind: "dispatch",
action: { id: "agent.interrupt", scope: "global" },
});
});
});

describe("routeKeyboardShortcut — workspace.tab.navigate", () => {
Expand Down
7 changes: 7 additions & 0 deletions packages/app/src/keyboard/route-shortcut.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,13 @@ export function routeKeyboardShortcut(
): ShortcutAction {
const passthrough = PASSTHROUGH_DISPATCH[input.action];
if (passthrough) {
if (
input.action === "agent.interrupt" &&
ctx.pathname.startsWith("/settings") &&
!ctx.isMobile
) {
return { kind: "navigate-last-workspace" };
}
return dispatch(passthrough);
}

Expand Down
4 changes: 4 additions & 0 deletions packages/app/src/lib/overlay-root.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ function getTopWebOverlay(): WebOverlayEntry | undefined {
}, undefined);
}

export function hasActiveWebOverlay(): boolean {
return getTopWebOverlay() !== undefined;
}

function getFocusableElements(scope: HTMLElement): HTMLElement[] {
const selector = [
"a[href]",
Expand Down