chore(legal): relicense to MIT and add PATENTS notice - #55
Conversation
e59b2dc to
b5ce51c
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: getoptimum/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe README changes the license badge and License section from Ms-RSL to MIT. The section adds patent-rights information and links to Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
b5ce51c to
f6c05b4
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
7fadb65 to
44cad07
Compare
Replace the Microsoft Reference Source License with the unmodified MIT License, and update the README badge and License section accordingly. Add PATENTS, listing all 49 patent families licensed to Spice Solutions Inc. by CodeOn. MIT grants copyright permissions only and grants no patent rights, so the notice matters more here than in the source-available repositories: recipients should not read MIT as conferring patent peace. Ship PATENTS in the container image alongside the LICENSE, NOTICE and THIRD-PARTY-NOTICES.md that are already copied to /usr/share/doc/optimum-gateway/.
44cad07 to
5a531c7
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 13: Update the license statement in SECURITY.md to reference the MIT
License instead of Ms-RSL, while preserving the separate safe-harbor permission
language.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: getoptimum/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 845c1aa1-500e-4e35-aab3-2113d63a6b89
⛔ Files ignored due to path filters (5)
LICENSEis excluded by none and included by noneNOTICEis excluded by none and included by nonePATENTSis excluded by none and included by nonedocs/sbom-full.jsonis excluded by none and included by nonedocs/sbom.jsonis excluded by none and included by none
📒 Files selected for processing (2)
DockerfileREADME.md
A marking notice advertises live rights. Listing rights whose term has ended, or that lapsed for non-payment, is the fact pattern false-marking claims are built on, so they are removed rather than shown in a separate section.
The safe harbor was written around Ms-RSL granting only read-only reference use, so it had to add permission to build and run the software. MIT already grants that, making the permission redundant. More importantly, the closing paragraph withheld the right to distribute, create derivative works, and use in production. MIT grants all three, so that text contradicted the LICENSE and read as clawing back rights. Reframed as what a safe harbor is actually for: an authorization and non-prosecution assurance for security testing, which no copyright license addresses. The good-faith conditions are unchanged.
Replaces the Microsoft Reference Source License with the unmodified MIT License, updates the README badge and License section, and adds
PATENTS. AppendsPATENTSto the existing DockerfileCOPYso it ships to/usr/share/doc/optimum-gateway/alongside the other legal files.The notice matters more here than in the source-available repos. MIT grants copyright permissions only and no patent rights, but most engineers read MIT as "safe to use". Someone who adopts this gateway, wires it to an RLNC engine and runs a network is practicing CodeOn patents with no license from anyone. The
PATENTSfile therefore carries a different disclaimer here, stating plainly that MIT confers no patent rights.MIT is nonetheless the right permissive choice, and safer than Apache-2.0 — Apache §3 contains an express patent grant, and we cannot grant patent rights we hold only under license.
PATENTSlists the licensed rights grouped by jurisdiction under a "may be covered by one or more" statement, the usual form for virtual marking. 121 entries covering the live rights on the schedule.For v2, not for this PR: third parties are not expected to build this binary yet, so MIT on the source is fine today. Two things need resolving before that changes at v2, when the gateway moves to
mump2p-protocol:go.modstill pullsgithub.com/getoptimum/rlnctransitively (indirect, via the pinnedoptimum-p2p v0.0.1-rc12.2). Currentoptimum-p2phas no such dependency, so a bump plusgo mod tidyshould clear it.optimum-p2pdirectly, which is not becoming source-viewable. A third party building from MIT source would need a grant for that dependency.optimum-p2pgets its ownPATENTSfile in getoptimum/optimum-p2p#275, since marking follows distribution rather than source visibility.Written with Claude Code
Summary by CodeRabbit