Skip to content

feat: quic cleanup - #33

Merged
abergasov merged 1 commit into
_quic_tryfrom
feat/mump2p-quic-cleanup
Jul 30, 2026
Merged

feat: quic cleanup#33
abergasov merged 1 commit into
_quic_tryfrom
feat/mump2p-quic-cleanup

Conversation

@swarna1101

@swarna1101 swarna1101 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Improvements

    • Enhanced QUIC-based connectivity for improved transport reuse and connection handling.
    • Removed an outdated stream timeout adjustment, supporting more consistent connection behavior.
  • Tests

    • Added coverage confirming that nodes can start successfully with QUIC-enabled configurations.

@swarna1101
swarna1101 requested a review from a team as a code owner July 30, 2026 09:00
@swarna1101
swarna1101 requested review from abergasov and removed request for a team July 30, 2026 09:00
@coderabbitai
coderabbitai Bot requested a review from CryptoFewka July 30, 2026 09:00
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: getoptimum/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 73a5b061-2424-4bca-8481-1711e273641b

📥 Commits

Reviewing files that changed from the base of the PR and between 8a8f1ac and b4e8fa0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum and included by none
📒 Files selected for processing (2)
  • pkg/service/mum_p2p/node_test.go
  • pkg/service/mum_p2p/service.go

📝 Walkthrough

Walkthrough

mum_p2p.NewNode now configures libp2p with QUIC reuse transport and connection management, removes the previous mplex stream timeout reset, and drops the prior mux/security wiring. A smoke test creates a node using the optimum_quic_smoke configuration and a free port, verifies successful creation, and registers cleanup.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: abergasov, cryptofewka

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title is relevant, but it does not follow the required (<domain/pkg>): format because the scope is missing. Use a scoped title such as feat(mum_p2p): cleanup QUIC transport setup, keeping it under 72 characters and without trailing punctuation.
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@abergasov
abergasov merged commit c191284 into _quic_try Jul 30, 2026
4 checks passed
@abergasov
abergasov deleted the feat/mump2p-quic-cleanup branch July 30, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants