nginx: don't regenerate bad-host SSL cert - #2096
Merged
Merged
Conversation
* other keys are only generated if they don't exist * generation is fast, but it's still a waste of effort
This was referenced Jul 30, 2026
alxndrsn
marked this pull request as ready for review
July 30, 2026 04:32
Member
|
This isn't a user-facing change, right? I.e., we don't expect users to be changing/replacing those files? It makes sense to me as a way to speed up tests. |
matthew-white
approved these changes
Jul 30, 2026
alxndrsn
changed the title
alxndrsn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
It originally span out of #2066 when I was re-running the tests a lot and trying to speed things up.
Why is this the best possible solution? Were any other approaches considered?
Consistent with surrounding code - other keys are only generated if they don't exist.
How does this change impact users? Describe intentional behavior changes from code updates. What are the regression risks?
Speeds up nginx startup a tiny bit.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.