nginx: remove ssl_trusted_certificate - #2033
Merged
Merged
Conversation
This setting is only relevant if either `ssl_verify_client` or `ssl_stapling` is enabled. Neither setting is. Any deployer who does require client certificate verification is likely sophisticated enough to re-enable themselves. Closes getodk#831
alxndrsn
marked this pull request as ready for review
July 2, 2026 08:30
Member
|
@alxndrsn How does this change perform when testing with ssllabs.com |
Contributor
Author
It has no visible effect on ssllabs.com scoring. I would not have expected any effect anyway, as the setting only affects client certificate validation, which:
|
yanokwa
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setting is only relevant if either
ssl_verify_clientorssl_staplingis enabled. Neither setting is.See: https://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_trusted_certificate
Any deployer who does require client certificate verification is likely sophisticated enough to re-enable themselves.
Closes #831
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
This setting is only relevant if either
ssl_verify_clientorssl_staplingis enabled. Neither setting is.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No effect likely; self-hosters who use self-signed server certificates + client SSL certificates might be affected, but it seems like an unlikely combination.
No obvious related discussion in either of
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)