Fixed optimized (wrapped) percentiles #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
commented
Sep 16, 2019
| "github.com/getlantern/msgpack" | ||
| ) | ||
|
|
||
| // PERCENTILEOPT returns an optimized PERCENTILE that wraps an existing | ||
| // PERCENTILE and reuses its storage. |
There was a problem hiding this comment.
We no longer attempt to reuse the existing percentile's storage, we assume separate storage for this percentile.
oxtoacart
commented
Sep 16, 2019
| Percentile Expr | ||
| } | ||
|
|
||
| func (e *ptileOptimized) Validate() error { |
There was a problem hiding this comment.
Most of this stuff is now inherited from ptile.
oxtoacart
commented
Sep 16, 2019
| defer wg.Done() | ||
|
|
||
| sqlString := ` | ||
| SELECT PERCENTILE(pp_5p, 90) AS pp_opt |
There was a problem hiding this comment.
This shows an example of what's now possible.
There was a problem hiding this comment.
Cool! Thanks also, the context is helpful.
|
Thanks @hwh33! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows queries to use PERCENTILE expressions that wrap existing PERCENTILEs.