Added facility for tracking and exposing basic database-level stats #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forkner
reviewed
Jun 7, 2018
| func QueuedForFollower(followerID int, queued int) { | ||
| mx.Lock() | ||
| defer mx.Unlock() | ||
| followerStats[followerID].Queued = queued |
There was a problem hiding this comment.
It looks okay by eyeball -- but could followerStats[followerID] be nil here if it was in a race for the lock with FollowerFailed and FollowerFailed wins?
It looks like markFailed can only be triggered from a read that starts strictly after processing that follower, but it's a bit subtle, so just wanted to check if that was the expectation.
There was a problem hiding this comment.
Yes, that is the expectation. Great question!
|
@oxtoacart looks okay to me, not sure how to interpret the CI results. master also seems to be having issues. |
forkner
approved these changes
Jun 7, 2018
|
Thanks @forkner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #12.