Merge pull request #87 from getlantern/ox/issue86

Added validation for all tables to have a resolution

table.go

@@ -143,6 +143,9 @@ func (db *DB) CreateTable(opts *TableOpts) error {
 	db.orderedTables = append(db.orderedTables, t)
 
 	if !t.Virtual {
+		if q.Resolution <= 0 {
+			return errors.New("Please specify a resolution for the table using PERIOD(...)")
+		}
 		var rsErr error
 		var offsetsBySource common.OffsetsBySource
 		if !t.db.opts.Passthrough {

zenodb_test.go

@@ -145,6 +145,14 @@ view_a:
 		return
 	}
 
+	// try to create a table that's missing a resolution
+	createErr := db.CreateTable(&TableOpts{
+		Name:            "bad",
+		RetentionPeriod: 1 * time.Hour,
+		SQL:             "SELECT * FROM inbound WHERE r = 'A' GROUP BY *",
+	})
+	assert.Error(t, createErr)
+
 	now := epoch
 	advance := func(d time.Duration) {
 		time.Sleep(250 * time.Millisecond)