misc(events-processor): Extract records processing logic #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrocolic
approved these changes
Nov 7, 2025
groyoh
reviewed
Nov 7, 2025
| fetches := cg.client.PollRecords(context.Background(), 10000) | ||
| if fetches.IsClientClosed() { | ||
| cg.logger.Info("client closed") | ||
| return |
Contributor
There was a problem hiding this comment.
@vincent-pochet this is not the same behaviour. Before we returned from poll when client got closed. Now we will loop indefinitely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is part of the Pre-aggregation epic, it follows #606
The main goal of this feature is to setup a complete aggregation pipeline that will be leveraged to compute the customer usage without re-querying the full set of events.
Description
This PR is the last preparatory PR before #608. The goal is to extract the record processing logic into simpler function that will make it easier to add graceful shutdown