-
Notifications
You must be signed in to change notification settings - Fork 136
feat(integration): Update billing entity mappings in integration payload #4450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
groyoh
wants to merge
1
commit into
feat/entity-integration-mapping
Choose a base branch
from
feat/entity-integration-payload
base: feat/entity-integration-mapping
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(integration): Update billing entity mappings in integration payload #4450
groyoh
wants to merge
1
commit into
feat/entity-integration-mapping
from
feat/entity-integration-payload
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63feea3 to
ea18887
Compare
ef4bf5a to
a7bb294
Compare
6965ce6 to
6e544ef
Compare
a7bb294 to
d7ea4ee
Compare
f66b227 to
395e62c
Compare
ivannovosad
suggested changes
Oct 9, 2025
ivannovosad
approved these changes
Oct 9, 2025
Contributor
Author
|
Thanks for the review @ivannovosad 🙏 |
julienbourdeau
approved these changes
Oct 9, 2025
395e62c to
ebe1186
Compare
d7ea4ee to
cd1999e
Compare
ebe1186 to
d1d5639
Compare
cd1999e to
55052ce
Compare
d1d5639 to
17c5de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, our customers cannot sync invoices to multiple accounting entities (subsidiaries) as our mapping is made at the organization level. However, in NetSuite, for instance, the tax and item mapping are made at the entity level. We need to allow our mapping to be defined at the entity level.
Description
This is a follow-up PR to #4445 and #4446.
This makes sure that each integration rely on the correct integration mapping or integration collection mapping following this order:
To make sure the behavior is correctly handled on all integrations, I'll heavily update the tests in an other PR.