Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added method for generating uniq hash #43

Closed
wants to merge 1 commit into from

Conversation

pandwoter
Copy link

@pandwoter pandwoter commented Oct 30, 2020

Hello, I'm planning to use this method for implementing hash generation in particular providers as follows

def kubeconfig_path
  File.join(
    kubeconfig_dir,
    "#{environment.app_name.downcase}" \
    "-#{generate_hash(config.access_token + config.cluster_id)}" \
    "-kubeconfig.yaml"
  )
end

Also, I created PR for digital ocean provider (getkuby/kuby-digitalocean#3)
So if the implementation is ok, let me know and I will do it for other providers too

(this PR is a part of #40)

@camertron
Copy link
Member

Please see comments on getkuby/kuby-digitalocean#3. TL;DR is I'd like to see the generate_hash function defined in the provider gems instead of in the Provider superclass.

@pandwoter
Copy link
Author

Implemented in Provider superclass

@pandwoter pandwoter closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants