Fix RFC3339 validation #1104
Open
Fix RFC3339 validation #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI specifies the format `date-time` as RFC3339 compliant. In a RFC3339 `date-time` the `time-offset` is a required component. The current RFC3339 validation regex defines the `time-offset` as an optional component. This leads to errors where a timestamp is considered valid by the library but the value still cannot be parsed into a `time.Time`. This change makes the `time-offset` a required component. Relevant tests are changed accordingly. Links: - https://datatracker.ietf.org/doc/html/rfc3339#section-5.6 Fixes: getkin#1031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI specifies the format
date-timeas RFC3339 compliant. In a RFC3339date-timethetime-offsetis a required component.The current RFC3339 validation regex defines the
time-offsetas an optional component. This leads to errors where a timestamp is considered valid by the library but the value still cannot be parsed into atime.Time.This change makes the
time-offseta required component. Relevant tests are changed accordingly.Links:
Fixes: #1031