Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ditto instance retain cycle in PresenceViewer #5

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

bplattenburg
Copy link
Member

Based on @magicwave 's changes in getditto/DittoSwiftTools#167, but in the new presence viewer source of truth.

@magicwave
Copy link
Contributor

@bplattenburg - With this standalone repo would we expect to import the DittoSwiftTools package without the PresenceViewer module and independently import this package? Currently this produces an SPM conflict on import. Or maybe the PresenceViewer module will be removed from DST package?

@bplattenburg
Copy link
Member Author

@bplattenburg - With this standalone repo would we expect to import the DittoSwiftTools package without the PresenceViewer module and independently import this package? Currently this produces an SPM conflict on import. Or maybe the PresenceViewer module will be removed from DST package?

@magicwave The intent is that DittoSwiftTools depends on this package, and customers would only need to import that. getditto/DittoSwiftTools#166 makes those changes to depend on this repository and remove the duplicate copy.

@bplattenburg bplattenburg merged commit 2b7f93c into main Jan 2, 2025
@bplattenburg bplattenburg deleted the BP/retain_cycle branch January 2, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants