fix: prevent request hanging in Bun by selectively forwarding headers#253
fix: prevent request hanging in Bun by selectively forwarding headers#253shrutikcs wants to merge 1 commit intoget-convex:mainfrom
Conversation
|
@shrutikcs is attempting to deploy a commit to the Convex Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe token retrieval logic in Next.js integration now selectively forwards only Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This PR fixes an issue where internal authentication requests hang indefinitely when running in the Bun runtime.
When using Bun with Next.js, the integration encounters two main issues during server-side authentication:
Solution:
Modified the getToken logic to:
This prevents problematic headers like Content-Length or Host from being incorrectly carried over.
Fixes #249
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Summary by CodeRabbit