Skip to content

fix: widen better-auth peer dependency to >=1.4.9 <1.5.0#245

Open
ramonclaudio wants to merge 1 commit intoget-convex:mainfrom
ramonclaudio:fix/peer-dep-better-auth-range
Open

fix: widen better-auth peer dependency to >=1.4.9 <1.5.0#245
ramonclaudio wants to merge 1 commit intoget-convex:mainfrom
ramonclaudio:fix/peer-dep-better-auth-range

Conversation

@ramonclaudio
Copy link

@ramonclaudio ramonclaudio commented Jan 28, 2026

Summary

  • Widens better-auth peer dependency from exact 1.4.9 to >=1.4.9 <1.5.0, covering v1.4.9 through v1.4.18
  • All imports use stable better-auth submodule paths verified compatible across the entire 1.4.x range
  • Excludes 1.5.0 which removes createAuthEndpoint/createAuthMiddleware from better-auth/plugins (moved to better-auth/api), removes the better-auth/adapters/test export path, and deletes runAdapterTest entirely

Closes #232

@vercel
Copy link

vercel bot commented Jan 28, 2026

@ramonclaudio is attempting to deploy a commit to the Convex Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

The peer dependency constraint for better-auth in package.json was updated from a fixed version "1.4.9" to a version range ">=1.4.9 <1.5.0", allowing compatible minor patch versions while maintaining backward compatibility.

Changes

Cohort / File(s) Summary
Dependency Version Constraint
package.json
Updated peer dependency for better-auth from fixed version 1.4.9 to range >=1.4.9 <1.5.0, enabling use of compatible patch releases.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version range, oh what delight,
No longer pinned to a single height,
Now patches flow freely through the gate,
Updates arrive—no need to wait!
From 1.4.9, the bugs take flight. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #232's objective to remove the exact pin on better-auth, but uses a narrower range (>=1.4.9 <1.5.0) than the issue's implied preference (^1.4.9) and PR objectives mention (^1.4.9). Consider aligning the version constraint with the broader ^1.4.9 range mentioned in PR objectives, or clarify why the narrower <1.5.0 upper bound is necessary for compatibility.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: widening the better-auth peer dependency version constraint from a fixed version to a range.
Out of Scope Changes check ✅ Passed The PR only modifies package.json peer dependency specification, which is directly in scope for addressing issue #232's request to widen the version constraint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramonclaudio ramonclaudio changed the title fix: widen better-auth peer dependency to ^1.4.9 fix: better-auth 1.5.0 compatibility Jan 29, 2026
@ramonclaudio ramonclaudio force-pushed the fix/peer-dep-better-auth-range branch from 87c2110 to 78b4d17 Compare January 29, 2026 22:46
The peer dependency was pinned to exactly 1.4.9, preventing users from
installing better-auth 1.4.10+ which includes bug fixes and improvements.
All imports use stable better-auth submodule paths that are compatible
across the 1.4.x range. Excludes 1.5.0 which has breaking import path
changes that require source updates.

Closes get-convex#232
@ramonclaudio ramonclaudio force-pushed the fix/peer-dep-better-auth-range branch from 78b4d17 to 6a11f17 Compare January 29, 2026 22:49
@ramonclaudio ramonclaudio changed the title fix: better-auth 1.5.0 compatibility fix: widen better-auth peer dependency to >=1.4.9 <1.5.0 Jan 29, 2026
@frailbongat
Copy link
Contributor

Hoping this can be merged soon, we’re blocked on better-auth 1.4.11 support in our project. Thanks for the work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@convex-dev/better-auth fixed/pinned to 1.4.9

2 participants