-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rinex-cli interpretation of rx-geo #215
Conversation
The rx-geo parameter expects lat/lon in degrees, but the geodetic2ecef function wants them in radians. This leads to positions being wildly incorrect. This commit switches to calling the GroundPosition::from_geodetic function instead, which is happy to directly recieve the lat/lon/alt tuple as-is without conversion.
Hello @jigpu Good catch, thanks for your contribution once again. FYI: i was planning on releasing a new version in early April, because I'd like to squeeze in some more work. |
@gwbres No need to change the schedule on my account. I'm literally just blindly playing around in waters far beyond my depth and reporting issues along the way 😅 I learned about "RINEX" only a week ago after looking into Android's raw GPS ability. I've been doing a lot of bumbling around in a (perhaps overly-ambitious 😆) attempt to get something to turn the data recorded from my phone into a position. I'm still having trouble getting the rinex-cli position solver to do much with that data. *Actually, it has a small issue with the data from the reference station. It spits out a EDIT: Actually, looks like even the data from the reference station just shows a single point at the apriori position... I must definitely be doing something wrong 😕 |
really awesome, I can only encourage ! If you're motivated enough, let's just switch to our Discord channel (you can join in for free and tie it to your github account for instance), it will be better suited to discuss complex topics
Position solving is the most advanced topic, I'm the app author and probably the only person that has used this opmode to this day, so this is not surprizing. If I get it right, you manage to get your phone spit out its signal observations as a RINEX (Observation) file.
24o are the signal observations (carrier signals), 24n are the ephemerides (SV messages broadcasted over radio at that time), and SP3 are high precision orbits (SV attitude, post processed by some laboratories).
Do you care enough to share an example of your Observation Data so I can reproduce on my side ?
My recommendation would be to take advantage of the logger ( |
The rx-geo parameter expects lat/lon in degrees, but the geodetic2ecef function wants them in radians. This leads to positions being wildly incorrect. This commit switches to calling the GroundPosition::from_geodetic function instead, which is happy to directly recieve the lat/lon/alt tuple as-is without conversion.