Fix rinex-cli commands #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes several errors that are encountered when trying to use the identify
command:
- The "all" and "anomalies" arguments were using the same short
option identifier 'a'. The former has been renamed to 'A'.
- The "header" argument had a short option identifier 'h' that
conflicted with the implicit "help". The short option has been
removed for "header".
- The "station" argument was duplicated in its entirety
Fixes: 6fc9190
A runtime error is encountered when trying to use this command because there is no "no-graph" option anymore that these commands conflict with. Fixes: 6fc9190
Rust panics with a variation of following error when trying to pass either of these options to rinex-cli: ~~~ Mismatch between definition and access of `rx-ecef`. Could not downcast to &alloc::string::String, need to downcast to alloc::string::String ~~~ Fixes: 6fc9190
gwbres
approved these changes
Mar 23, 2024
|
Hello @jigpu thank you for your contribution ! FYI, I just opened this Discussion where people can share their thoughts on our existing ecosystem and help us improve it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several runtime crashes that I ran into while trying to use rinex-cli.