-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tests for arm64 #199
Conversation
src/lib.rs
Outdated
//! assert_relative_eq!(result.x(), 158458.67, epsilon=1e-2); | ||
//! assert_relative_eq!(result.y(), -434296.88, epsilon=1e-2); | ||
//! assert_relative_eq!(result.x(), 158460.19, epsilon=1e-2); | ||
//! assert_relative_eq!(result.y(), -434297.05, epsilon=1e-2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other changes don't really concern me, but this one feels like a somewhat large change. I'm not sure why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu x86_64 value: 158458.67251293262
macos14 arm64 value: 158460.18744483538
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea why the difference would be this pronounced. Hmm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it's a local only issue. The GH runners are close (enough) to the recorded values. I'm not sure what's going on, but not really worried about it if it's only my machine.
(lazy web: how do I clear my downloaded grid cache?)
e822c6b
to
df7bffc
Compare
df7bffc
to
5615965
Compare
failure:
retrying... |
No description provided.